Fix F#/C# versions for .NET 6/7 #8949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loboistaken
approved these changes
Dec 12, 2023
mairaw
commented
Dec 12, 2023
release-notes/7.0/releases.json
Outdated
| "csharp-version": "10.0-preview", | ||
| "fsharp-version": "6.0-preview", | ||
| "csharp-version": "10.0", | ||
| "fsharp-version": "7.0", | ||
| "vb-version": "15.5", |
There was a problem hiding this comment.
should this be 16.9 like the others?
There was a problem hiding this comment.
yes nothing has changed with VB language versions.
jaredpar
approved these changes
Dec 12, 2023
|
@jaredpar I realized I had added the wrong C# version for .NET 7 on my changes. So requesting a new review after my changes to make sure I didn't make other mistakes. |
jaredpar
approved these changes
Dec 14, 2023
rbhanda
approved these changes
Dec 14, 2023
mairaw
commented
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got a customer feedback for the site complaining about .NET 7 needing to support F# 7
It seems we decreased the version starting with 7.0.11
Fixes https://github.com/dotnet/website/issues/5834