Close unused diagnostic server thread handle (#27141)

Fixes #27135
dotnet · Oct 11, 2019 · d8bbcc4 · d8bbcc4
1 parent 58b016c
commit d8bbcc4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/vm/diagnosticserver.cpp b/src/vm/diagnosticserver.cpp
@@ -21,7 +21,6 @@
 
 IpcStream::DiagnosticsIpc *DiagnosticServer::s_pIpc = nullptr;
 Volatile<bool> DiagnosticServer::s_shuttingDown(false);
-HANDLE DiagnosticServer::s_hServerThread = INVALID_HANDLE_VALUE;
 
 DWORD WINAPI DiagnosticServer::DiagnosticsServerThread(LPVOID)
 {
@@ -147,15 +146,15 @@ bool DiagnosticServer::Initialize()
             auto_trace_launch();
 #endif
             DWORD dwThreadId = 0;
-            s_hServerThread = ::CreateThread( // TODO: Is it correct to have this "lower" level call here?
+            HANDLE hServerThread = ::CreateThread( // TODO: Is it correct to have this "lower" level call here?
                 nullptr,                     // no security attribute
                 0,                           // default stack size
                 DiagnosticsServerThread,     // thread proc
                 (LPVOID)s_pIpc,              // thread parameter
                 0,                           // not suspended
                 &dwThreadId);                // returns thread ID
 
-            if (s_hServerThread == NULL)
+            if (hServerThread == NULL)
             {
                 delete s_pIpc;
                 s_pIpc = nullptr;
@@ -169,6 +168,8 @@ bool DiagnosticServer::Initialize()
             }
             else
             {
+                ::CloseHandle(hServerThread);
+
 #ifdef FEATURE_AUTO_TRACE
                 auto_trace_wait();
 #endif

diff --git a/src/vm/diagnosticserver.h b/src/vm/diagnosticserver.h
@@ -48,7 +48,6 @@ class DiagnosticServer final
 private:
     static IpcStream::DiagnosticsIpc *s_pIpc;
     static Volatile<bool> s_shuttingDown;
-    static HANDLE s_hServerThread;
 };
 
 #endif // FEATURE_PERFTRACING