-
Notifications
You must be signed in to change notification settings - Fork 2.7k
add test with deep execution tree without stores. #10835
Conversation
…'t spill trees from time to time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding this.
Is there a reason the existing https://github.com/dotnet/coreclr/blob/master/tests/src/JIT/jit64/opt/cse/hugeexpr1.cs is insufficient for this scenario? |
I didn't see any failures in ci when I disabled stack spilling and send PR. |
Hm. I am pretty sure that we're already covering this somewhere... LGTM if we aren't, in any case. |
I want to double check. |
It is pretty interesting that we see this failure only in Windows_NT x64 Debug Build and Test. It is what I tested locally. And as you see there are no failures on existing tests. |
now it fails in Checked and Release.
Ok, now it looks fine. It breaks in all modes (x64/x86 Debug/Release/Checked). |
It will not fail if the compiler spills trees from eeStack from time to time or all recursive walkers are replaced by non-recursive algorithms.