This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add TryGetOwnedMemory #16455
Merged
Add TryGetOwnedMemory #16455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
force-pushed
the
TryGetOwnedMemory
branch
from
f494053
to
8902500
Compare
stephentoub
reviewed
Feb 20, 2018
| where TOwner : OwnedMemory<T> | ||
| { | ||
| ownedMemory = readOnlyMemory.GetObjectStartLength(out int index, out int length) as TOwner; | ||
| return !ReferenceEquals(ownedMemory, null); |
There was a problem hiding this comment.
Does the JIT'd code end up fetching ownedMemory again? Wondering if there's any value in this being:
TOwner tmp;
ownedMemory = tmp = readOnlyMemory.GetObjectStartLength(out int index, out int length) as TOwner;
return !ReferenceEquals(tmp, null);There was a problem hiding this comment.
Ah, so its reg rather than ref; good idea
stephentoub
approved these changes
Feb 20, 2018
stephentoub
approved these changes
Feb 21, 2018
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Feb 21, 2018
* Add TryGetOwnedMemory * Feedback * spelling Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
to dotnet/corert
that referenced
this pull request
Feb 21, 2018
* Add TryGetOwnedMemory * Feedback * spelling Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Feb 21, 2018
* Add TryGetOwnedMemory * Feedback * spelling Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corefx
that referenced
this pull request
Feb 21, 2018
* Add TryGetOwnedMemory * Feedback * spelling Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Feb 21, 2018
* Add TryGetOwnedMemory * Feedback * spelling Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Feb 21, 2018
* Add TryGetOwnedMemory * Feedback * spelling Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
JeremyKuhne
pushed a commit
to JeremyKuhne/corefx
that referenced
this pull request
Feb 21, 2018
* Add TryGetOwnedMemory * Feedback * spelling Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
kbaladurin
pushed a commit
to kbaladurin/corert
that referenced
this pull request
Mar 15, 2018
* Add TryGetOwnedMemory * Feedback * spelling Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/dotnet/corefx/issues/27237
With dotnet/corefx#27288
/cc @stephentoub