-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Edits to fix conflicts in generated Vector.cs file #16666
Conversation
Fixed minor space changes and one syntax error that causes conflict between checked in Vector.cs file and the freshly auto-generated Vector.cs file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for fixing these conflicts.
I assume you ran the .tt file, and the generated .cs file is completely up-to-date.
I have used the online editor to do the changes. Hence will be monitoring this PR for the builds. These are the changes that are identical to what I have in my sandbox and compile fine... |
Note that the .tt generator only runs manually in VS, it doesn't run as part of the build. That's why/how the files got out of sync. |
@eerhardt purposely put a WIP while I'm monitoring the builds...
Ah. ok. now I understand. The code edits that I have done to tt file will generate the matching cs file. So that way we are good, I guess... |
Fixed minor space changes and one syntax error that causes conflict between checked in Vector.cs file and the freshly auto-generated Vector.cs file.
This is as per the discussion at this link.
@eerhardt Please review the changes.
Thanks,
Mandar