This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add Sort(...) extension methods for Span<T> #16986
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,175 @@ | ||
| using System.Diagnostics; | ||
| using System.Runtime.CompilerServices; | ||
|
|
||
| #if !netstandard | ||
| using Internal.Runtime.CompilerServices; | ||
| #endif | ||
|
|
||
| namespace System | ||
| { | ||
| // TODO: Rename to SpanSortHelpers before move to corefx | ||
| internal static partial class SpanSortHelpersCommon | ||
| { | ||
|
|
||
| // This is the threshold where Introspective sort switches to Insertion sort. | ||
| // Empirically, 16 seems to speed up most cases without slowing down others, at least for integers. | ||
| // Large value types may benefit from a smaller number. | ||
| internal const int IntrosortSizeThreshold = 16; | ||
|
|
||
| internal static int FloorLog2PlusOne(int n) | ||
| { | ||
| Debug.Assert(n >= 2); | ||
| int result = 2; | ||
| n >>= 2; | ||
| while (n > 0) | ||
| { | ||
| ++result; | ||
| n >>= 1; | ||
| } | ||
| return result; | ||
| } | ||
|
|
||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| internal static void Swap<T>(ref T items, int i, int j) | ||
| { | ||
| Debug.Assert(i != j); | ||
| Swap(ref Unsafe.Add(ref items, i), ref Unsafe.Add(ref items, j)); | ||
| } | ||
|
|
||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| internal static void Swap<T>(ref T a, ref T b) | ||
| { | ||
| T temp = a; | ||
| a = b; | ||
| b = temp; | ||
| } | ||
|
|
||
| // This started out with just LessThan. | ||
| // However, due to bogus comparers, comparables etc. | ||
| // we need to preserve semantics completely to get same result. | ||
| internal interface IDirectComparer<in T> | ||
| { | ||
| bool GreaterThan(T x, T y); | ||
| bool LessThan(T x, T y); | ||
|
There was a problem hiding this comment. Can we use default implementation syntax? If yes perhaps we could get more short source code. |
||
| bool LessThanEqual(T x, T y); // TODO: Delete if we are not doing specialize Sort3 | ||
| } | ||
| // | ||
| // Type specific DirectComparer(s) to ensure optimal code-gen | ||
| // | ||
| internal struct SByteDirectComparer : IDirectComparer<sbyte> | ||
| { | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool GreaterThan(sbyte x, sbyte y) => x > y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThan(sbyte x, sbyte y) => x < y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThanEqual(sbyte x, sbyte y) => x <= y; | ||
| } | ||
| internal struct ByteDirectComparer : IDirectComparer<byte> | ||
| { | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool GreaterThan(byte x, byte y) => x > y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThan(byte x, byte y) => x < y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThanEqual(byte x, byte y) => x <= y; | ||
| } | ||
| internal struct Int16DirectComparer : IDirectComparer<short> | ||
| { | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool GreaterThan(short x, short y) => x > y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThan(short x, short y) => x < y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThanEqual(short x, short y) => x <= y; | ||
| } | ||
| internal struct UInt16DirectComparer : IDirectComparer<ushort> | ||
| { | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool GreaterThan(ushort x, ushort y) => x > y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThan(ushort x, ushort y) => x < y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThanEqual(ushort x, ushort y) => x <= y; | ||
| } | ||
| internal struct Int32DirectComparer : IDirectComparer<int> | ||
| { | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool GreaterThan(int x, int y) => x > y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThan(int x, int y) => x < y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThanEqual(int x, int y) => x <= y; | ||
| } | ||
| internal struct UInt32DirectComparer : IDirectComparer<uint> | ||
| { | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool GreaterThan(uint x, uint y) => x > y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThan(uint x, uint y) => x < y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThanEqual(uint x, uint y) => x <= y; | ||
| } | ||
| internal struct Int64DirectComparer : IDirectComparer<long> | ||
| { | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool GreaterThan(long x, long y) => x > y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThan(long x, long y) => x < y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThanEqual(long x, long y) => x <= y; | ||
| } | ||
| internal struct UInt64DirectComparer : IDirectComparer<ulong> | ||
| { | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool GreaterThan(ulong x, ulong y) => x > y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThan(ulong x, ulong y) => x < y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThanEqual(ulong x, ulong y) => x <= y; | ||
| } | ||
| internal struct SingleDirectComparer : IDirectComparer<float> | ||
| { | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool GreaterThan(float x, float y) => x > y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThan(float x, float y) => x < y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThanEqual(float x, float y) => x <= y; | ||
| } | ||
| internal struct DoubleDirectComparer : IDirectComparer<double> | ||
| { | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool GreaterThan(double x, double y) => x > y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThan(double x, double y) => x < y; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThanEqual(double x, double y) => x <= y; | ||
| } | ||
| // TODO: Revise whether this is needed | ||
| internal struct StringDirectComparer : IDirectComparer<string> | ||
| { | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool GreaterThan(string x, string y) => x.CompareTo(y) > 0; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThan(string x, string y) => x.CompareTo(y) < 0; | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool LessThanEqual(string x, string y) => x.CompareTo(y) <= 0; | ||
| } | ||
|
|
||
| internal interface IIsNaN<T> | ||
| { | ||
| bool IsNaN(T value); | ||
| } | ||
| internal struct SingleIsNaN : IIsNaN<float> | ||
| { | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool IsNaN(float value) => float.IsNaN(value); | ||
| } | ||
| internal struct DoubleIsNaN : IIsNaN<double> | ||
| { | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public bool IsNaN(double value) => double.IsNaN(value); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit add period at the end.