Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Set -march=armv7-a for Alpine Linux ARM32 #17730

Merged
merged 3 commits into from Apr 23, 2018
Merged

Set -march=armv7-a for Alpine Linux ARM32 #17730

merged 3 commits into from Apr 23, 2018

Conversation

ghost
Copy link

@ghost ghost commented Apr 22, 2018

Alpine ARM32 (armhf) comes with ARMv6 ABI with default ISA set to ARMv6 (16-bit instruction set) due to which the build fails at very beginning on Alpine ARM32 (1%).

Setting armv7-a in build option enables the usage of 32-bit instructions (like dmb ish) that CoreCLR is using.

This takes the build quite farther, but I haven't gotten to 100% yet.
Builds 100% of coreclr+tests on Alpine ARM32.

Related to #17468.

@ghost ghost mentioned this pull request Apr 23, 2018
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@janvorli janvorli merged commit 8ea97b1 into dotnet:master Apr 23, 2018
@ghost ghost deleted the alpinearmhf branch April 23, 2018 21:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant