This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Port to 2.1 - Don't check for libintl.h on OSX #20118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janvorli
added
area-PAL
Servicing-consider
|
cc: @dagood |
jamshedd
added
Servicing-approved
|
Approved for 2.1.6. |
|
@dotnet-bot test this please |
|
@dotnet-bot test Windows_NT x64 Formatting please |
|
@dotnet-bot test Windows_NT arm64 Cross Checked Innerloop Build and Test please |
|
Apparently CI1 Jenkins is currently experiencing problems. |
|
@dotnet-bot test Windows_NT arm64 Cross Checked Innerloop Build and Test please @janvorli feel free to merge when we get this green.. |
RussKeldorph
added
Servicing-consider
|
Kicking back to |
|
@dotnet-bot test Windows_NT arm64 Cross Checked Innerloop Build and Test please |
|
@janvorli could you ask someone to sign off on code review? Just so we stick to the letter of the rules 😃 |
vivmishra
added
Servicing-approved
|
Approved for 2.1.7 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The build fails to link if HAVE_LIBINTL_H is set when building on a Mac. libintl is unexpected on OSX and isn't configured correctly. This change makes OSX builds always ignore libintl. The intent is to use native internationalization anyway, so not using this library is correct.
Customer Impact
Building coreclr repo on OSX fails if libintl is installed.
[edit] libintl is on our OSX images because ASP.NET Core needs libintl installed on Mac agents to build
Regression?
No
Risk
No
Original issue: #20092