-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Port to 2.1 - Don't check for libintl.h on OSX #20118
Port to 2.1 - Don't check for libintl.h on OSX #20118
Conversation
cc: @dagood |
Approved for 2.1.6. |
@dotnet-bot test this please |
@dotnet-bot test Windows_NT x64 Formatting please |
@dotnet-bot test Windows_NT arm64 Cross Checked Innerloop Build and Test please |
Apparently CI1 Jenkins is currently experiencing problems. |
@dotnet-bot test Windows_NT arm64 Cross Checked Innerloop Build and Test please @janvorli feel free to merge when we get this green.. |
Kicking back to |
@dotnet-bot test Windows_NT arm64 Cross Checked Innerloop Build and Test please |
@janvorli could you ask someone to sign off on code review? Just so we stick to the letter of the rules 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for porting! 🙂
Approved for 2.1.7 |
Description
The build fails to link if HAVE_LIBINTL_H is set when building on a Mac. libintl is unexpected on OSX and isn't configured correctly. This change makes OSX builds always ignore libintl. The intent is to use native internationalization anyway, so not using this library is correct.
Customer Impact
Building coreclr repo on OSX fails if libintl is installed.
[edit] libintl is on our OSX images because ASP.NET Core needs libintl installed on Mac agents to build
Regression?
No
Risk
No
Original issue: #20092