This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Move Native Library APIs to NativeLibrary class #21821
Merged
+689
−625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Jan 5, 2019
| /// <exception cref="System.ArgumentNullException">If libraryPath is null</exception> | ||
| /// <exception cref="System.DllNotFoundException ">If the library can't be found.</exception> | ||
| /// <exception cref="System.BadImageFormatException">If the library is not valid.</exception> | ||
| public static IntPtr LoadLibrary(string libraryPath) |
There was a problem hiding this comment.
Is Library still needed in the method names now that the Library is in the type name? "Library" in the
method names looks superfluous:
var handle = NativeLibrary.LoadLibrary("foo")
var p = NativeLibrary.GetLibraryExport(handle, "m");There was a problem hiding this comment.
Thanks; The Library is dropped in the new version of the API. I'll fix this.
jkotas
reviewed
Jan 5, 2019
src/vm/nativelibrarynative.cpp
Outdated
| // | ||
|
|
||
| // | ||
| // FCall's for the PInvoke classlibs |
src/System.Private.CoreLib/src/System/Runtime/InteropServices/NativeLibrary.cs
Outdated
Show resolved
Hide resolved
|
Thanks for the feedback @AaronRobinsonMSFT and @jkotas |
|
@dotnet-bot test CentOS7.1 x64 Debug Innerloop Build |
Move APIs that manipulate native libraries from System.Runtime.InteropServices.Marshal class to the new System.Runtime.InteropServices.NativeLibrary class. In API review: #32015, The LoadLibrary APIs were originally Approved to live in System.Runtime.InteropServices.Marshal class. However, recently the decision was changed such that the APIs are in a new NativeLibrary class.
swaroop-sridhar
force-pushed
the
NativeLibrary
branch
from
b20b30e to
f1933b7
Compare
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test please |
sandreenko
pushed a commit
to sandreenko/coreclr
that referenced
this pull request
Jan 8, 2019
Move APIs that manipulate native libraries from System.Runtime.InteropServices.Marshal class to the new System.Runtime.InteropServices.NativeLibrary class. In API review: #32015, The LoadLibrary APIs were originally Approved to live in System.Runtime.InteropServices.Marshal class. However, recently the decision was changed such that the APIs are in a new NativeLibrary class.
swaroop-sridhar
added a commit
to swaroop-sridhar/corefx
that referenced
this pull request
Jan 12, 2019
Expose the System.Runtime.Interop.NativeLibrary APIs implemented in CoreCLR. API review: #32015 CoreCLR Change: dotnet/coreclr#21821
swaroop-sridhar
added a commit
to swaroop-sridhar/corefx
that referenced
this pull request
Jan 17, 2019
Expose the System.Runtime.Interop.NativeLibrary APIs implemented in CoreCLR. API review: #32015 CoreCLR Change: dotnet/coreclr#21821 Tests for the API are here: https://github.com/dotnet/coreclr/blob/master/tests/src/Interop/NativeLibrary/NativeLibraryTests.cs
jkotas
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 17, 2019
Expose the System.Runtime.Interop.NativeLibrary APIs implemented in CoreCLR. API review: #32015 CoreCLR Change: dotnet/coreclr#21821 Tests for the API are here: https://github.com/dotnet/coreclr/blob/master/tests/src/Interop/NativeLibrary/NativeLibraryTests.cs
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Move APIs that manipulate native libraries from System.Runtime.InteropServices.Marshal class to the new System.Runtime.InteropServices.NativeLibrary class. In API review: dotnet/coreclr#32015, The LoadLibrary APIs were originally Approved to live in System.Runtime.InteropServices.Marshal class. However, recently the decision was changed such that the APIs are in a new NativeLibrary class. Commit migrated from dotnet/coreclr@110835b
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Expose the System.Runtime.Interop.NativeLibrary APIs implemented in CoreCLR. API review: dotnet/corefx#32015 CoreCLR Change: dotnet/coreclr#21821 Tests for the API are here: https://github.com/dotnet/coreclr/blob/master/tests/src/Interop/NativeLibrary/NativeLibraryTests.cs Commit migrated from dotnet/corefx@5241ad4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move APIs that manipulate native libraries from
System.Runtime.InteropServices.Marshal class to the new
System.Runtime.InteropServices.NativeLibrary class.
In API review: #32015,
The LoadLibrary APIs were originally Approved to live in
System.Runtime.InteropServices.Marshal class.
However, recently the decision was changed such that the APIs are
in a new NativeLibrary class.