This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add Span<T>.Sort(...) by changing Array.Sort internals to be Span based #24419
Closed
Closed
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
8e1dce1
Try changing Array.Sort to work on Spans first...
nietras 7bf009b
change Array public back, but add sort to memory extensions
nietras d7d9713
remove line
nietras c9d5906
revert BinarySearch
nietras 05c1a04
fix binarysearch in interface
nietras 6079482
Add dummy TrySZSort overload
nietras ddd36d7
Cleanup Sort Span public methods a bit
nietras 056709d
Convert Array to Span via Unsafe
nietras 6a31593
Remove not need TrySZSort overload
nietras ad27730
Change Span Sort API to follow approved API (does not compile)
nietras 66f88b9
Initial TComparer support
nietras 178b1ed
ArraySortHelper<TKey, TValue> TComparer
nietras a0ef68e
comment
nietras 7700cb1
Remove AggressiveInlining attributes
nietras d0740c9
Revert "ArraySortHelper<TKey, TValue> TComparer"
nietras 1b3fe24
Undo last TComparer stuff
nietras ff2d950
AggressiveInlining SwapIfGreaterWithItems
nietras 22ccaea
`in` trial (easy to do so testing it)
nietras e497563
Remove AggresiveInlining
nietras c6affb2
avoiding lo and hi
nietras 9e600d4
Add AggressiveInlining to Swap(
nietras 7a047a8
AggressiveInlining
nietras 5c1cc96
Swap( remove `in`
nietras 2a81a55
Revert "avoiding lo and hi"
nietras 4cac6a9
remove AggresiveInlining for Swap(
nietras 8d68c43
Revert "remove AggresiveInlining for Swap("
nietras a6a553c
Remove TODO comments
nietras 7f6296b
cleanup to limit changes
nietras f8a35ee
readd MemoryExtensions span methods
nietras 74cafec
remove some debug.asserts
nietras 992ef7a
remove more debug asserts
nietras 9c56769
cleanup CoreCLR file
nietras 32bc189
remove comment
nietras e352bc3
Remove comment
nietras cdda4ba
fix nullable
nietras 7de0096
fix nullable
nietras f1031b8
remove unnecessary changes, fix nullables ? (master seems to have cha…
nietras 93648bc
merge master
nietras 66044d7
Fix TODO-NULLABLE
nietras 1c1e877
empty line after throw
nietras 478632e
Add "using System.Runtime.CompilerServices;"
nietras 11dd34a
Merge branch 'master' into ntr/span-sort-2
nietras File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be
GetRawSzArrayData()