Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Replace gtLclNum with GetLclNum() #26853

Merged
merged 3 commits into from
Sep 25, 2019
Merged

Replace gtLclNum with GetLclNum() #26853

merged 3 commits into from
Sep 25, 2019

Conversation

franksinankaya
Copy link

@sandreenko
Copy link

Looks like there is a failure with this change:

Assert failure(PID 3588 [0x00000e04], Thread: 2996 [0x0bb4]): Assertion failed '!m_lsra->isRegCandidate(varDsc)' in 'System.Numerics.Vector:Narrow(struct,struct):struct' (IL size 76)

    File: f:\workspace.2\_work\1\s\src\jit\lower.h Line: 366
    Image: F:\workspace.2\_work\1\s\bin\Product\Windows_NT.arm64.Checked\x64\crossgen.exe

I do not see a change in this PR that could cause it, but I have not seen this failure before, so it could be a regression. I will rerun the testing.

cc @dotnet/jit-contrib

franksinankaya
franksinankaya commented Sep 24, 2019
View reviewed changes
src/jit/importer.cpp Outdated Show resolved Hide resolved
@franksinankaya
Copy link
Author

/azp run coreclr-ci

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 26853 in repo dotnet/coreclr

@franksinankaya
Copy link
Author

@sandreenko : yet another permission issue. Can you kickstart the test again?

@franksinankaya
Copy link
Author

@dotnet-bot test coreclr-ci

@sandreenko
Copy link

the test run looks good, the failures are from #26551, I am going to merge then without retesting (or you will have to rebase your changes to get the fix for the regression).

sandreenko
sandreenko approved these changes Sep 24, 2019
View reviewed changes
Copy link

@sandreenko sandreenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandreenko sandreenko merged commit c8ad76d into dotnet:master Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandreenko sandreenko sandreenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franksinankaya @sandreenko