This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
A couple fixes to p/invoke marshalling pregeneration #27286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MichalStrehovsky
commented
Oct 18, 2019
MichalStrehovsky
commented
- Expose the PreserveSig bit on PInvokeMetadata and reject precompiling methods with HResult munging
- Parse CustomMarshaller records to avoid asserting
- Place marshalling cleanup in a new cleanup stream that runs in a finally block
- Place SafeHandle code into the cleanup stream
* Expose the PreserveSig bit on PInvokeMetadata and reject precompiling methods with HResult munging * Parse CustomMarshaller records to avoid asserting * Place marshalling cleanup in a new cleanup stream that runs in a finally block * Place SafeHandle code into the cleanup stream
|
Cc @sergiy-k |
| ILCodeStream cleanupCodestream = pInvokeILCodeStreams.CleanupCodeStream; | ||
|
|
||
| // Marshalling is wrapped in a finally block to guarantee cleanup | ||
| ILExceptionRegionBuilder tryFinally = emitter.NewFinallyRegion(); |
There was a problem hiding this comment.
This relies on the codegen to remove empty finally regions. I assume it's fine since RyuJIT does that. I kind of forgot to design the ILExceptionRegionBuilder in a way where we could change our mind about the exception region later...
jkotas
approved these changes
Oct 18, 2019
jkoritzinsky
approved these changes
Oct 18, 2019
|
/azp run coreclr-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.