This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Remove empty lines caused by empty fusion log string #27471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vitek-karas @elinor-fung Does this interact with the assembly loader tracing improvements? |
jkotas
reviewed
Oct 27, 2019
src/vm/clrex.cpp
Outdated
| @@ -1850,7 +1845,7 @@ OBJECTREF EEFileLoadException::CreateThrowable() | |||
| ARG_SLOT args[] = { | |||
| ObjToArgSlot(gc.pNewException), | |||
| ObjToArgSlot(gc.pNewFileString), | |||
| ObjToArgSlot(gc.pFusLogString), | |||
| NULL, | |||
There was a problem hiding this comment.
If you wanted to, you can go one step further and delete the string? fusionLog argument from the constructor in FileLoadException.CoreCLR.cs, BadImageFormatException.CoreCLR.cs and FileNotFoundException.CoreCLR.cs and not pass this NULL here at all. (It would also need changing gsig_IM_Str_Str_Int_RetVoid a few lines above to gsig_IM_Str_Int_RetVoid.)
vitek-karas
approved these changes
Oct 27, 2019
|
Hello @danmosemsft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fusion Logs are not relevant to CoreCLR (as far as I know). Pass null, not empty string, to the FileLoadException. (It was causing extra lines in the exception output.)