Bail out in SystemNative_CopyFile if access fails. We don't want to p…

…roceed if the destination file is read-only.
dotnet · May 13, 2019 · 780171d · 780171d
1 parent 4636a2d
commit 780171d
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/src/Native/Unix/System.Native/pal_io.c b/src/Native/Unix/System.Native/pal_io.c
@@ -1219,13 +1219,16 @@ int32_t SystemNative_CopyFile(intptr_t sourceFd, const char* srcPath, const char
 #if HAVE_CLONEFILE
         // For clonefile we need to unlink the destination file first but we need to
         // check permission first to ensure we don't try to unlink read-only file
-        if (access(destPath, W_OK) == 0)
+        if (access(destPath, W_OK) != 0)
         {
-            ret = unlink(destPath);
-            if (ret != 0)
-            {
-                return ret;
-            }
+            errno = EACCES;
+            return -1;
+        }
+
+        ret = unlink(destPath);
+        if (ret != 0)
+        {
+            return ret;
         }
 #endif
     }