Merge pull request #11821 from bartdesmet/MathPowReflectionCache

Math.Pow reflection caching
dotnet · Sep 17, 2016 · bffef76 · bffef76
2 parents 46494bb + e5c4cf3
commit bffef76
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/System.Linq.Expressions/src/System/Linq/Expressions/BinaryExpression.cs b/src/System.Linq.Expressions/src/System/Linq/Expressions/BinaryExpression.cs
@@ -7,6 +7,7 @@
 using System.Diagnostics;
 using System.Dynamic.Utils;
 using System.Reflection;
+using static System.Linq.Expressions.CachedReflectionInfo;
 
 namespace System.Linq.Expressions
 {
@@ -2874,8 +2875,7 @@ public static BinaryExpression Power(Expression left, Expression right, MethodIn
             RequiresCanRead(right, nameof(right));
             if (method == null)
             {
-                Type mathType = typeof(System.Math);
-                method = mathType.GetMethod("Pow", BindingFlags.Static | BindingFlags.Public);
+                method = Math_Pow_Double_Double;
                 if (method == null)
                 {
                     throw Error.BinaryOperatorNotDefined(ExpressionType.Power, left.Type, right.Type);
@@ -2929,8 +2929,7 @@ public static BinaryExpression PowerAssign(Expression left, Expression right, Me
             RequiresCanRead(right, nameof(right));
             if (method == null)
             {
-                Type mathType = typeof(System.Math);
-                method = mathType.GetMethod("Pow", BindingFlags.Static | BindingFlags.Public);
+                method = Math_Pow_Double_Double;
                 if (method == null)
                 {
                     throw Error.BinaryOperatorNotDefined(ExpressionType.PowerAssign, left.Type, right.Type);

diff --git a/src/System.Linq.Expressions/src/System/Linq/Expressions/Common/CachedReflectionInfo.cs b/src/System.Linq.Expressions/src/System/Linq/Expressions/Common/CachedReflectionInfo.cs
@@ -149,5 +149,10 @@ internal static class CachedReflectionInfo
         public  static MethodInfo   Decimal_op_Implicit_Char =>
                                   s_Decimal_op_Implicit_Char ?? 
                                  (s_Decimal_op_Implicit_Char = typeof(decimal).GetMethod("op_Implicit", new[] { typeof(char) }));
+
+        private static MethodInfo s_Math_Pow_Double_Double;
+        public  static MethodInfo   Math_Pow_Double_Double =>
+                                  s_Math_Pow_Double_Double ??
+                                 (s_Math_Pow_Double_Double = typeof(Math).GetMethod(nameof(Math.Pow), new[] { typeof(double), typeof(double) }));
     }
 }