Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracking UWP test leg disable/re-enable for Vector<T> #24901

Closed
joshfree opened this issue Feb 2, 2018 · 1 comment
Closed

tracking UWP test leg disable/re-enable for Vector<T> #24901

joshfree opened this issue Feb 2, 2018 · 1 comment
Assignees
@nattress @eerhardt
Labels
area-Infrastructure-libraries test-enhancement Improvements of test source code tracking-external-issue The issue is caused by external problem (e.g. OS) - nothing we can do to fix it directly
Milestone
2.1.0

Comments

@joshfree
Copy link
Member

joshfree commented Feb 2, 2018

Due to timing issues with consuming dotnet/coreclr#16133 across coreclr / corert / .NET Native, we'll need to temporarily disable the UWP test leg in the corefx repo. Once .NET Native is updated to react to the Vector typeforward, we'll re-enable the test leg - sometime next week Feb 5 - Feb9.

cc: @eerhardt @nattress
jkotas referenced this issue in jkotas/corefx Feb 4, 2018
@jkotas
Disable UAP legs per #26802
d5bcfa6
jkotas referenced this issue in dotnet/corefx Feb 4, 2018
@jkotas
Disable UAP legs per #26802 (#26822)
120dce4
@jkotas
Copy link
Member

jkotas commented Feb 10, 2018

These 3 commits should be undone once this is fixed:

dotnet/corefx@120dce4
dotnet/corefx@2202b4f
dotnet/corefx@a296c86

nattress referenced this issue in nattress/corefx Feb 28, 2018
@nattress
Revert "Disable UAP legs per #26802 (dotnet#26822)"
64c8626 
This reverts commit 120dce4.
nattress referenced this issue in nattress/corefx Feb 28, 2018
@nattress
Revert "Disable UAP legs per #26802 (dotnet#26822)"
165d993 
This reverts commit 120dce4.
nattress referenced this issue in nattress/corefx Mar 1, 2018
@nattress
Revert "Disable UAP legs per #26802 (dotnet#26822)"
c06f564 
This reverts commit 120dce4.
nattress referenced this issue in nattress/corefx Mar 1, 2018
@nattress
Revert "Disable UAP legs per #26802 (dotnet#26822)"
da98236 
This reverts commit 120dce4.
nattress referenced this issue in dotnet/corefx Mar 2, 2018
@nattress
Re-enable UAP builds (#27531)
c9cdfba 
* Build uapaot System.Numerics.Vectors

With `Vector<T>` now residing in System.Private.CoreLib, directly reference System.Private.Corelib instead of contracts just like netcoreapp does.

Add uapaot flavor since System.Private.CoreLib has a different strong name key on that platform.

* Make EnsureExtendedPrefixOverMaxPath available to UAP

Add the helper method `System.IO.PathInternal.EnsureExtendedPrefixOverMaxPath` to Common\src\System\IO\PathInternal.Windows.cs. It was previously not visible to UAP since  Common\src\CoreLib\System\IO\PathInternal.Windows.cs is not included in UAP compilation.

* Keep SocketsHttpHandler out of UAP builds

SocketsHttpHandler is not supported in uap and is currently leaking into UAP builds since they've been disabled for a few weeks. Adjust the contract so it's not available to UAP, and clean the implementation assembly so SocketsHttpHandler internals don't leak out into HttpClientHandler.Core.cs.

* Fix GetAddrInfoExSupportsOverlapped UAP build break

`System.Net.NameResolutionPal.GetAddrInfoExSupportsOverlapped` uses LoadLibraryExW which is not compatible with UAP (which only supports LoadLibrary of DLLs within a container). Refactor the helper so UAP returns false.

* Revert "Disable UAP legs per #26802 (#26822)"

This reverts commit 120dce4.

* Revert "Disable UAP configurations in all configurations build"

This reverts commit 2202b4f.

* Revert "Disable UAP official builds (#26871)"

This reverts commit ef79caf.

- Baseline the ApiCompat and GenFacades failures in System.Runtime.Extensions and System.Threading.ThreadPool.
- Adjust naming of files to match branch conventions
- Fix up some configuration issues with uap packaging. The CoreFX.Private.TestUtilities packaging needs updated build tools which can map between uwp6.0 and netstandard2.0.
- ifdef out Thread.GetCurrentProcessorId until we get a new System.Private.CoreLib.
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.1.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nattress nattress

@eerhardt eerhardt

Labels
area-Infrastructure-libraries test-enhancement Improvements of test source code tracking-external-issue The issue is caused by external problem (e.g. OS) - nothing we can do to fix it directly
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
5 participants
@nattress @joshfree @jkotas @eerhardt @msftgits