Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Disable UAP legs per #26802 #26822

Merged
merged 1 commit into from
Feb 4, 2018
Merged

Disable UAP legs per #26802 #26822

merged 1 commit into from
Feb 4, 2018

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Feb 4, 2018

No description provided.

@jkotas
Copy link
Member Author

jkotas commented Feb 4, 2018

cc @joshfree @nattress

@jkotas jkotas merged commit 120dce4 into dotnet:master Feb 4, 2018
@jkotas jkotas deleted the disable-uaplegs branch February 4, 2018 16:40
@karelz karelz added this to the 2.1.0 milestone Feb 4, 2018
nattress added a commit to nattress/corefx that referenced this pull request Feb 28, 2018
nattress added a commit to nattress/corefx that referenced this pull request Feb 28, 2018
nattress added a commit to nattress/corefx that referenced this pull request Mar 1, 2018
nattress added a commit to nattress/corefx that referenced this pull request Mar 1, 2018
nattress added a commit that referenced this pull request Mar 2, 2018
* Build uapaot System.Numerics.Vectors

With `Vector<T>` now residing in System.Private.CoreLib, directly reference System.Private.Corelib instead of contracts just like netcoreapp does.

Add uapaot flavor since System.Private.CoreLib has a different strong name key on that platform.

* Make EnsureExtendedPrefixOverMaxPath available to UAP

Add the helper method `System.IO.PathInternal.EnsureExtendedPrefixOverMaxPath` to Common\src\System\IO\PathInternal.Windows.cs. It was previously not visible to UAP since  Common\src\CoreLib\System\IO\PathInternal.Windows.cs is not included in UAP compilation.

* Keep SocketsHttpHandler out of UAP builds

SocketsHttpHandler is not supported in uap and is currently leaking into UAP builds since they've been disabled for a few weeks. Adjust the contract so it's not available to UAP, and clean the implementation assembly so SocketsHttpHandler internals don't leak out into HttpClientHandler.Core.cs.

* Fix GetAddrInfoExSupportsOverlapped UAP build break

`System.Net.NameResolutionPal.GetAddrInfoExSupportsOverlapped` uses LoadLibraryExW which is not compatible with UAP (which only supports LoadLibrary of DLLs within a container). Refactor the helper so UAP returns false.

* Revert "Disable UAP legs per #26802 (#26822)"

This reverts commit 120dce4.

* Revert "Disable UAP configurations in all configurations build"

This reverts commit 2202b4f.

* Revert "Disable UAP official builds (#26871)"

This reverts commit ef79caf.

- Baseline the ApiCompat and GenFacades failures in System.Runtime.Extensions and System.Threading.ThreadPool.
- Adjust naming of files to match branch conventions
- Fix up some configuration issues with uap packaging. The CoreFX.Private.TestUtilities packaging needs updated build tools which can map between uwp6.0 and netstandard2.0.
- ifdef out Thread.GetCurrentProcessorId until we get a new System.Private.CoreLib.
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
* Build uapaot System.Numerics.Vectors

With `Vector<T>` now residing in System.Private.CoreLib, directly reference System.Private.Corelib instead of contracts just like netcoreapp does.

Add uapaot flavor since System.Private.CoreLib has a different strong name key on that platform.

* Make EnsureExtendedPrefixOverMaxPath available to UAP

Add the helper method `System.IO.PathInternal.EnsureExtendedPrefixOverMaxPath` to Common\src\System\IO\PathInternal.Windows.cs. It was previously not visible to UAP since  Common\src\CoreLib\System\IO\PathInternal.Windows.cs is not included in UAP compilation.

* Keep SocketsHttpHandler out of UAP builds

SocketsHttpHandler is not supported in uap and is currently leaking into UAP builds since they've been disabled for a few weeks. Adjust the contract so it's not available to UAP, and clean the implementation assembly so SocketsHttpHandler internals don't leak out into HttpClientHandler.Core.cs.

* Fix GetAddrInfoExSupportsOverlapped UAP build break

`System.Net.NameResolutionPal.GetAddrInfoExSupportsOverlapped` uses LoadLibraryExW which is not compatible with UAP (which only supports LoadLibrary of DLLs within a container). Refactor the helper so UAP returns false.

* Revert "Disable UAP legs per dotnet/corefx#26802 (dotnet/corefx#26822)"

This reverts commit dotnet/corefx@120dce4.

* Revert "Disable UAP configurations in all configurations build"

This reverts commit dotnet/corefx@2202b4f.

* Revert "Disable UAP official builds (dotnet/corefx#26871)"

This reverts commit dotnet/corefx@ef79caf.

- Baseline the ApiCompat and GenFacades failures in System.Runtime.Extensions and System.Threading.ThreadPool.
- Adjust naming of files to match branch conventions
- Fix up some configuration issues with uap packaging. The CoreFX.Private.TestUtilities packaging needs updated build tools which can map between uwp6.0 and netstandard2.0.
- ifdef out Thread.GetCurrentProcessorId until we get a new System.Private.CoreLib.


Commit migrated from dotnet/corefx@c9cdfba
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants