This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[Unix] Passing extra CMake args #26792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for compiler and linker additional arguments in CMake. By using CLR_ADDITIONAL_LINKER_FLAGS and CLR_ADDITIONAL_COMPILER_OPTIONS it's possible to pass toolchain options without changing build scripts.
|
@dotnet-bot test UWP CoreCLR x64 Debug Build |
|
@dotnet-bot test UWP CoreCLR x64 Debug Build |
|
I don't access to see details of UWP build. @janvorli @weshaggard could you share error details? |
|
@dotnet-bot test UWP CoreCLR x64 Debug Build |
|
logs seem to be gone I tried to re-trigger the build leg |
|
@weshaggard still be unreachable. |
|
@dotnet-bot test UWP CoreCLR x64 Debug Build |
|
It doesn't seem to want to retrigger those runs. @dotnet-bot help |
|
Welcome to the dotnet/corefx Repository The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR The following commands are valid for all PRs and repositories. Click to expand
The following jobs are launched by default for each PR against dotnet/corefx:master. Click to expand
The following optional jobs are available in PRs against dotnet/corefx:master. Click to expand
Have a nice day! |
|
@dotnet/dnceng any ideas why the UWP runs aren't retriggering? |
|
@weshaggard This commit removed them: 120dce4 |
|
Nevermind I see the UWP runs were disabled with #26822. @alpencolt lets ignore those build legs. |
|
@janvorli you know more about cmake then I do can you please review this PR? |
|
Welcome to the dotnet/corefx Repository The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR The following commands are valid for all PRs and repositories. Click to expand
The following jobs are launched by default for each PR against dotnet/corefx:master. Click to expand
The following optional jobs are available in PRs against dotnet/corefx:master. Click to expand
Have a nice day! |
|
Thanks @alpencolt |
|
Thank you too! |
|
@weshaggard thank you for rewiewing the change while I was OOF. It looks good to me. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Added support for compiler and linker additional arguments in CMake. By using CLR_ADDITIONAL_LINKER_FLAGS and CLR_ADDITIONAL_COMPILER_OPTIONS it's possible to pass toolchain options without changing build scripts. Commit migrated from dotnet/corefx@3c24c32
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for compiler and linker additional arguments in CMake.
By using CLR_ADDITIONAL_LINKER_FLAGS and CLR_ADDITIONAL_COMPILER_OPTIONS
it's possible to pass toolchain options without changing build scripts.
Part of #26508. @janvorli please take a look. Say if more detailed description is needed.