This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Initial IsolatedStorage implementation #11080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,3 @@ | |||
| Compat issues with assembly System.IO.IsolatedStorage: | |||
| CannotAddAbstractMembers : Member 'System.IO.IsolatedStorage.IsolatedStorage.GetPermission(System.Security.PermissionSet)' is abstract in the implementation but is missing in the contract. | |||
| Total Issues: 1 | |||
There was a problem hiding this comment.
Whoops. I'll clear the duplicate file.
|
|
| internal static void CreateDirectory(string path, IsolatedStorageScope scope) | ||
| { | ||
| // ACL'ing isn't an issue in WinRT, just create it | ||
| Directory.CreateDirectory(path); |
There was a problem hiding this comment.
We can just use Directory.CreateDirectory at the call site then. No need for the scope. Etc.
There was a problem hiding this comment.
Other than I'm calling this helper in shared code. I figured it was better to call the helper here than not since it is there.
JeremyKuhne
force-pushed
the
IsolatedStorage
branch
from
dca64c5 to
afe6f68
Compare
Implements most of the APIs we intend to provide. Still pending are: - Size methods - Remove methods We do not plan to implement the store iterator or any factory methods that take arguments yet. Tests are forthcoming- the helper class is intended to facilitate unit testing as well as abstracting platform differences.
JeremyKuhne
force-pushed
the
IsolatedStorage
branch
from
afe6f68 to
7e6a492
Compare
JeremyKuhne
force-pushed
the
IsolatedStorage
branch
from
7e6a492 to
544806f
Compare
| <NuGetTargetMoniker>.NETStandard,Version=v1.7</NuGetTargetMoniker> | ||
| <ProjectGuid>{27225772-FE8B-49D7-8E58-29242D536130}</ProjectGuid> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(Configuration)' == 'Release'"> |
There was a problem hiding this comment.
Looks like VS updated some of these configurations. Can you please undo the setting of the OutputPath here, otherwise we will be dropping these files in the wrong outputs.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Initial IsolatedStorage implementation Commit migrated from dotnet/corefx@d7dde9d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements most of the APIs we intend to provide. Still pending are:
We do not plan to implement the store iterator or any factory methods that take arguments yet.
Tests are forthcoming- the helper class is intended to facilitate unit testing as well as abstracting platform differences. Also need to fix packages and UWP build.
This PR is NOT going in as is- this is to facilitate design feedback as I add tests and fix the packaging/UWP issues.
@ellismg; @weshaggard; @ericstj; @danmosemsft