Work around known issues in "Ubuntu on Windows" #11574
Conversation
|
Forgot to mention that I'm tracking all issues in https://github.com/dotnet/corefx/issues/11057. |
Woo hoo! |
| @@ -191,7 +191,7 @@ internal static bool TryReadStatFile(int pid, out ParsedStat result, ReusableTex | |||
| internal static bool TryReadStatFile(int pid, int tid, out ParsedStat result, ReusableTextReader reusableReader) | |||
| { | |||
| bool b = TryParseStatFile(GetStatFilePathForThread(pid, tid), out result, reusableReader); | |||
| Debug.Assert(!b || result.pid == tid, "Expected thread ID from stat file to match supplied tid"); | |||
| //Debug.Assert(!b || result.pid == tid, "Expected thread ID from stat file to match supplied tid"); | |||
There was a problem hiding this comment.
Why is this commented out? If it's necessary, could you add a comment explaining and linking to whatever the associated issue # is?
There was a problem hiding this comment.
Thanks for catching this; I thought I'd already added a comment here. Fixed.
|
A few comments/questions, but generally LGTM. It'll be nice to see these disabled tests get reenabled as the necessary support/fixes arrive. |
| { | ||
| var s = File.ReadAllText(versionFile); | ||
|
|
||
| if (s.Contains("Microsoft") || s.Contains("WSL")) |
There was a problem hiding this comment.
What is the chance that some Linux distribution will contain WSL as a substring in its /proc/version?
There was a problem hiding this comment.
I'm not sure...WSL sounds like an uncommon sequence of characters to me, but that's hard to predict. We could maybe do a little more rigorous parsing here, but I'm not sure it's worth the additional risk of getting things wrong. The worst-case scenario is that we stop running some tests on a distro where they should run, but at least there's a chance that whoever is porting to that distro will notice, since xunit prints messages about tests that were skipped conditionally.
|
@dotnet-bot test Innerloop OSX Release Build and Test please. |
The latest Windows 10 preview builds contain enough functionality in Ubuntu/Bash on Windows (a.k.a. Windows Subsystem for Linux, or WSL) that .NET Core mostly works now. With the fix for dotnet/corefx#11058, we can even build/test the CoreFx tree in this environment. Currently there are a few test failures; I've been working on identifying the causes of these, and filing bugs in the appropriate repos. This change implements workarounds for all of the current known issues in the "inner loop" tests. Mostly, I've just conditionally disabled tests when running in the WSL environment. There is still an issue, under investigation, causing non-deterministic failures in the System.Net.Http tests (Microsoft/BashOnWindowsdotnet/corefx#1068). And I haven't tried OuterLoop runs of anything but the networking tests. Commit migrated from dotnet/corefx@d9aa92f
The latest Windows 10 preview builds contain enough functionality in Ubuntu/Bash on Windows (a.k.a. Windows Subsystem for Linux, or WSL) that .NET Core mostly works now. With the fix for #11058, we can even build/test the CoreFx tree in this environment. Currently there are a few test failures; I've been working on identifying the causes of these, and filing bugs in the appropriate repos.
This change implements workarounds for all of the current known issues in the "inner loop" tests. Mostly, I've just conditionally disabled tests when running in the WSL environment.
There is still an issue, under investigation, causing non-deterministic failures in the System.Net.Http tests (microsoft/WSL#1068). And I haven't tried OuterLoop runs of anything but the networking tests.
Hopefully getting this merged will unblock other folks from trying Ubuntu on Windows in their own CoreFx workflows.