Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Add test for AppDomain.SetData with the same key multiple times #19657

Merged
merged 1 commit into from
May 15, 2017

Conversation

stephentoub
Copy link
Member

@stephentoub
Copy link
Member Author

Blocked on new coreclr coming in

@stephentoub
Copy link
Member Author

@dotnet-bot test this please

@stephentoub stephentoub merged commit 6e9eefa into dotnet:master May 15, 2017
@stephentoub stephentoub deleted the appdomainsetdata branch May 15, 2017 14:33
@ViktorHofer
Copy link
Member

@stephentoub This should be fixed, right? I'm still hitting the issue locally. I cleaned and built everything again today.

System.Tests.AppDomainTests.SetData_SameKeyMultipleTimes_ReplacesOldValue [FAIL]
        System.InvalidOperationException : SetData can only be used to set the value of a given name once.
        Stack Trace:
              at System.AppDomain.SetData(String name, Object data)
           C:\Users\vikto\Documents\src\corefx\src\System.Runtime.Extensions\src\System\AppDomain.cs(150,0): at System.
  AppDomain.SetData(String name, Object data)
           C:\Users\vikto\Documents\src\corefx\src\System.Runtime.Extensions\tests\System\AppDomainTests.cs(271,0): at
  System.Tests.AppDomainTests.SetData_SameKeyMultipleTimes_ReplacesOldValue()

@stephentoub
Copy link
Member Author

Yes, it's fixed.

I cleaned and built everything again today

After pulling down the latest in master? This is a deterministic failure, so if it weren't fixed, we would be seeing all legs in master fail as a result of this.

@ViktorHofer
Copy link
Member

Yeah it was with the lastest master bit. Okay, hopefully it won't pop up again for me.

@ViktorHofer
Copy link
Member

I just rebuilt everything, it is working now. Thanks!

@karelz karelz modified the milestone: 2.0.0 May 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants