Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Consolidate KnownColorTable.cs into a single shared source file #21007

Merged
merged 2 commits into from
Jun 13, 2017

Conversation

mellinoe
Copy link
Contributor

@hughbe I've taken part of your Pens/Brushes test PR and separated it out so we can re-enable the ColorTranslator tests.

  • Consolidate KnownColorTable.cs into a single shared file.
  • Hide Win32 PInvoke's behind a FEATURE_WINDOWS_SYSTEM_COLORS flag.
  • Add hard-coded system color constants for other platforms.
  • Re-enable the ColorTranslator tests

I think I still need to do something to make sure that the Win32 PInvokes are not used on Nano. I'm going to see what the test failures on Nano look like.

@mellinoe
Copy link
Contributor Author

@mellinoe mellinoe force-pushed the fix-colortranslator branch from ae0576a to d8eff11 Compare June 13, 2017 20:24
@mellinoe
Copy link
Contributor Author

@mellinoe
Copy link
Contributor Author

Windows Nano seems to have passed fine, despite the use of user32.dll!GetSysColor. I've filed #21011 to make sure this is ok.

@mellinoe mellinoe merged commit c58e53e into dotnet:master Jun 13, 2017
@karelz karelz modified the milestone: 2.1.0 Jun 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants