Disable test in System.Net.Sockets for UAP #21019

caesar-chen · 2017-06-13T22:54:58Z

Now System.Net.Sockets.Functional tests will run clean in both innerloop and outerloop for UAP.

I added the [Fact] label back for MulticastInterface_Set_AnyInterface_Succeeds(). The test will never run with only [Outerloop] label. See details here: 6257f45#commitcomment-22500352

Contributes to: #20135

dnfclas · 2017-06-13T22:55:04Z

@caesar1995,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.

It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot

dnfclas · 2017-06-13T23:00:00Z

@Caesar1995, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, .NET Foundation Pull Request Bot

davidsh · 2017-06-13T23:03:53Z

src/System.Net.Sockets/tests/FunctionalTests/LoggingTest.cs

@@ -13,7 +13,7 @@ namespace System.Net.Sockets.Tests
    public class LoggingTest : RemoteExecutorTestBase
    {
        [Fact]
-        [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "NetEventSource is only part of .NET Core")]
+        [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework | TargetFrameworkMonikers.Uap, "NetEventSource is only part of .NET Core and requires internal Reflection.")]


I think the SkipOnTargetFramework attribute should be left alone. This test will never run on .NET Framework.

However, skipping the test on Uap is temporary and will be solved as part of getting NetEventSource working on Uap. So, for now, you should add an ActiveIssue attribute for that and leave the SkipOnTargetFramework attribute alone.

Comment applies to similar changes below.

ok, will fix

caesar-chen · 2017-06-14T00:06:21Z

@davidsh Do I need to run Outerloop tests for my changes in this PR?

davidsh · 2017-06-14T00:20:42Z

@davidsh Do I need to run Outerloop tests for my changes in this PR?

Normally, no, because you only disabled tests.

But you also added back a Fact attribute which means you added a new test to Outerloop

public async Task MulticastInterface_Set_AnyInterface_Succeeds()

So, you should run Outerloop for Windows and *Nix on this PR.

caesar-chen · 2017-06-14T00:23:34Z

@dotnet-bot help

dotnet-bot · 2017-06-14T00:23:37Z

Welcome to the dotnet/corefx Repository

The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR

The following commands are valid for all PRs and repositories.

Click to expand

Comment Phrase	Action
@dotnet-bot test this please	Re-run all legs. Use sparingly
@dotnet-bot test ci please	Generates (but does not run) jobs based on changes to the groovy job definitions in this branch
@dotnet-bot help	Print this help message

The following jobs are launched by default for each PR against dotnet/corefx:master.

Click to expand

Comment Phrase	Job Launched
@dotnet-bot test Windows_NT Debug AllConfigurations Build	Windows_NT Debug AllConfigurations Build
@dotnet-bot test Innerloop netfx Windows_NT Debug x86 Build and Test	Innerloop netfx Windows_NT Debug x86 Build and Test
@dotnet-bot test Innerloop netfx Windows_NT Release x64 Build and Test	Innerloop netfx Windows_NT Release x64 Build and Test
@dotnet-bot test Innerloop OSX10.12 Debug x64 Build and Test	Innerloop OSX10.12 Debug x64 Build and Test
@dotnet-bot test Innerloop OSX10.12 Release x64 Build and Test	Innerloop OSX10.12 Release x64 Build and Test
@dotnet-bot test Innerloop Tizen armel Debug Cross Build	Innerloop Tizen armel Debug Cross Build
@dotnet-bot test Innerloop Tizen armel Release Cross Build	Innerloop Tizen armel Release Cross Build
@dotnet-bot test Vertical uap Build	Vertical uap Build
@dotnet-bot test Vertical uapaot Build	Vertical uapaot Build
@dotnet-bot test Innerloop Ubuntu14.04 arm Release Cross Build	Innerloop Ubuntu14.04 arm Release Cross Build
@dotnet-bot test Innerloop Ubuntu16.04 arm Debug Cross Build	Innerloop Ubuntu16.04 arm Debug Cross Build

The following optional jobs are available in PRs against dotnet/corefx:master.

Click to expand

Comment Phrase	Job Launched
@dotnet-bot test innerloop CentOS7.1 Debug	Queues Innerloop CentOS7.1 Debug x64 Build and Test
@dotnet-bot test innerloop CentOS7.1 Release	Queues Innerloop CentOS7.1 Release x64 Build and Test
@dotnet-bot test code coverage	Queues Code Coverage Windows Debug
@dotnet-bot test innerloop Debian8.4 Debug	Queues Innerloop Debian8.4 Debug x64 Build and Test
@dotnet-bot test innerloop Debian8.4 Release	Queues Innerloop Debian8.4 Release x64 Build and Test
@dotnet-bot test innerloop Fedora24 Debug	Queues Innerloop Fedora24 Debug x64 Build and Test
@dotnet-bot test innerloop Fedora24 Release	Queues Innerloop Fedora24 Release x64 Build and Test
@dotnet-bot test code formatter check	Queues Code Formatter Check
@dotnet-bot test innerloop OpenSUSE13.2 Debug	Queues Innerloop OpenSUSE13.2 Debug x64 Build and Test
@dotnet-bot test innerloop OpenSUSE13.2 Release	Queues Innerloop OpenSUSE13.2 Release x64 Build and Test
@dotnet-bot test innerloop OpenSUSE42.1 Debug	Queues Innerloop OpenSUSE42.1 Debug x64 Build and Test
@dotnet-bot test innerloop OpenSUSE42.1 Release	Queues Innerloop OpenSUSE42.1 Release x64 Build and Test
@dotnet-bot test outerloop netcoreapp CentOS7.1 Debug	Queues OuterLoop netcoreapp CentOS7.1 Debug x64
@dotnet-bot test outerloop netcoreapp CentOS7.1 Release	Queues OuterLoop netcoreapp CentOS7.1 Release x64
@dotnet-bot test outerloop netcoreapp Debian8.4 Debug	Queues OuterLoop netcoreapp Debian8.4 Debug x64
@dotnet-bot test outerloop netcoreapp Debian8.4 Release	Queues OuterLoop netcoreapp Debian8.4 Release x64
@dotnet-bot test outerloop netcoreapp Fedora24 Debug	Queues OuterLoop netcoreapp Fedora24 Debug x64
@dotnet-bot test outerloop netcoreapp Fedora24 Release	Queues OuterLoop netcoreapp Fedora24 Release x64
@dotnet-bot test outerloop netcoreapp OpenSUSE13.2 Debug	Queues OuterLoop netcoreapp OpenSUSE13.2 Debug x64
@dotnet-bot test outerloop netcoreapp OpenSUSE13.2 Release	Queues OuterLoop netcoreapp OpenSUSE13.2 Release x64
@dotnet-bot test outerloop netcoreapp OpenSUSE42.1 Debug	Queues OuterLoop netcoreapp OpenSUSE42.1 Debug x64
@dotnet-bot test outerloop netcoreapp OpenSUSE42.1 Release	Queues OuterLoop netcoreapp OpenSUSE42.1 Release x64
@dotnet-bot test outerloop netcoreapp OSX10.12 Debug	Queues OuterLoop netcoreapp OSX10.12 Debug x64
@dotnet-bot test outerloop netcoreapp OSX10.12 Release	Queues OuterLoop netcoreapp OSX10.12 Release x64
@dotnet-bot test outerloop netcoreapp PortableLinux Debug	Queues OuterLoop netcoreapp PortableLinux Debug x64
@dotnet-bot test outerloop netcoreapp PortableLinux Release	Queues OuterLoop netcoreapp PortableLinux Release x64
@dotnet-bot test outerloop netcoreapp RHEL7.2 Debug	Queues OuterLoop netcoreapp RHEL7.2 Debug x64
@dotnet-bot test outerloop netcoreapp RHEL7.2 Release	Queues OuterLoop netcoreapp RHEL7.2 Release x64
@dotnet-bot test outerloop netcoreapp Ubuntu14.04 Debug	Queues OuterLoop netcoreapp Ubuntu14.04 Debug x64
@dotnet-bot test outerloop netcoreapp Ubuntu14.04 Release	Queues OuterLoop netcoreapp Ubuntu14.04 Release x64
@dotnet-bot test outerloop netcoreapp Ubuntu16.04 Debug	Queues OuterLoop netcoreapp Ubuntu16.04 Debug x64
@dotnet-bot test outerloop netcoreapp Ubuntu16.04 Release	Queues OuterLoop netcoreapp Ubuntu16.04 Release x64
@dotnet-bot test outerloop netcoreapp Ubuntu16.10 Debug	Queues OuterLoop netcoreapp Ubuntu16.10 Debug x64
@dotnet-bot test outerloop netcoreapp Ubuntu16.10 Release	Queues OuterLoop netcoreapp Ubuntu16.10 Release x64
@dotnet-bot test outerloop netcoreapp Windows 7 Debug	Queues OuterLoop netcoreapp Windows 7 Debug x64
@dotnet-bot test outerloop netcoreapp Windows 7 Release	Queues OuterLoop netcoreapp Windows 7 Release x64
@dotnet-bot test outerloop netcoreapp Windows_NT Debug	Queues OuterLoop netcoreapp Windows_NT Debug x64
@dotnet-bot test outerloop netcoreapp Windows_NT Release	Queues OuterLoop netcoreapp Windows_NT Release x64
@dotnet-bot test outerloop netfx Windows_NT Debug	Queues OuterLoop netfx Windows_NT Debug x64
@dotnet-bot test outerloop netfx Windows_NT Release	Queues OuterLoop netfx Windows_NT Release x64
@dotnet-bot test innerloop PortableLinux Debug	Queues Innerloop PortableLinux Debug x64 Build and Test
@dotnet-bot test innerloop PortableLinux Release	Queues Innerloop PortableLinux Release x64 Build and Test
@dotnet-bot test innerloop RHEL7.2 Debug	Queues Innerloop RHEL7.2 Debug x64 Build and Test
@dotnet-bot test innerloop RHEL7.2 Release	Queues Innerloop RHEL7.2 Release x64 Build and Test
@dotnet-bot test innerloop Ubuntu14.04 arm Debug	Queues Innerloop Ubuntu14.04 arm Debug Cross Build
@dotnet-bot test innerloop Ubuntu14.04 Debug	Queues Innerloop Ubuntu14.04 Debug x64 Build and Test
@dotnet-bot test innerloop Ubuntu14.04 Release	Queues Innerloop Ubuntu14.04 Release x64 Build and Test
@dotnet-bot test innerloop Ubuntu16.04 arm Release	Queues Innerloop Ubuntu16.04 arm Release Cross Build
@dotnet-bot test innerloop Ubuntu16.04 Debug	Queues Innerloop Ubuntu16.04 Debug x64 Build and Test
@dotnet-bot test innerloop Ubuntu16.04 Release	Queues Innerloop Ubuntu16.04 Release x64 Build and Test
@dotnet-bot test innerloop Ubuntu16.10 Debug	Queues Innerloop Ubuntu16.10 Debug x64 Build and Test
@dotnet-bot test innerloop Ubuntu16.10 Release	Queues Innerloop Ubuntu16.10 Release x64 Build and Test
@dotnet-bot test innerloop Windows_NT Debug	Queues Innerloop Windows_NT Debug x86 Build and Test
@dotnet-bot test innerloop Windows_NT Release	Queues Innerloop Windows_NT Release x64 Build and Test

Have a nice day!

caesar-chen · 2017-06-14T00:25:21Z

@dotnet-bot test outerloop netcoreapp Windows 7 Release
@dotnet-bot test outerloop netcoreapp Windows_NT Debug
@dotnet-bot test outerloop netfx Windows_NT Debug
@dotnet-bot test outerloop netcoreapp OSX10.12 Debug
@dotnet-bot test outerloop netcoreapp Ubuntu16.10 Debug

caesar-chen · 2017-06-14T01:55:05Z

@dotnet-bot test Innerloop Tizen armel Release Cross Build (The build timed out)
@dotnet-bot test OuterLoop netcoreapp OSX10.12 Debug x64 (The plugin hasn't been performed correctly: Problem on deletion)

danmoseley · 2017-06-14T03:58:52Z

@dotnet-bot test OuterLoop netcoreapp OSX10.12 Debug x64 (The plugin hasn't been performed correctly: Problem on deletion)

danmoseley · 2017-06-14T04:06:32Z

@dotnet-bot test portable linux x64 release build (https://github.com/dotnet/corefx/issues/20441)

fix socket test outerloop runs

c4d3bb3

caesar-chen added area-System.Net.Sockets test-run-uwp-coreclr labels Jun 13, 2017

caesar-chen added this to the UWP6.0 milestone Jun 13, 2017

caesar-chen self-assigned this Jun 13, 2017

caesar-chen requested review from stephentoub, davidsh and CIPop June 13, 2017 22:54

dnfclas added the cla-required label Jun 13, 2017

dnfclas added cla-signed and removed cla-required labels Jun 13, 2017

davidsh added the os-windows-uwp label Jun 13, 2017

davidsh reviewed Jun 13, 2017

View reviewed changes

address PR feedback

30193fb

danmoseley approved these changes Jun 13, 2017

View reviewed changes

CIPop approved these changes Jun 13, 2017

View reviewed changes

davidsh approved these changes Jun 14, 2017

View reviewed changes

stephentoub approved these changes Jun 14, 2017

View reviewed changes

stephentoub merged commit 5344628 into dotnet:master Jun 14, 2017

caesar-chen deleted the socket_test branch June 14, 2017 17:36

karelz modified the milestones: UWP6.0, 2.1.0 Jun 16, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable test in System.Net.Sockets for UAP #21019

Disable test in System.Net.Sockets for UAP #21019

caesar-chen commented Jun 13, 2017 •

edited

Loading

dnfclas commented Jun 13, 2017

dnfclas commented Jun 13, 2017

davidsh Jun 13, 2017

caesar-chen Jun 13, 2017

caesar-chen commented Jun 14, 2017

davidsh commented Jun 14, 2017

caesar-chen commented Jun 14, 2017

dotnet-bot commented Jun 14, 2017

caesar-chen commented Jun 14, 2017

caesar-chen commented Jun 14, 2017

danmoseley commented Jun 14, 2017

danmoseley commented Jun 14, 2017

Disable test in System.Net.Sockets for UAP #21019

Disable test in System.Net.Sockets for UAP #21019

Conversation

caesar-chen commented Jun 13, 2017 • edited Loading

dnfclas commented Jun 13, 2017

dnfclas commented Jun 13, 2017

davidsh Jun 13, 2017

Choose a reason for hiding this comment

caesar-chen Jun 13, 2017

Choose a reason for hiding this comment

caesar-chen commented Jun 14, 2017

davidsh commented Jun 14, 2017

caesar-chen commented Jun 14, 2017

dotnet-bot commented Jun 14, 2017

caesar-chen commented Jun 14, 2017

caesar-chen commented Jun 14, 2017

danmoseley commented Jun 14, 2017

danmoseley commented Jun 14, 2017

caesar-chen commented Jun 13, 2017 •

edited

Loading