This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Updating version of UAP test tools and referencing the package from myget #21048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshaggard
approved these changes
Jun 14, 2017
|
LGTM. Thank @joperezr |
joperezr
force-pushed
the
FixMemoryMappedFiles
branch
from
daaaa83 to
5457041
Compare
|
Updated version of the uap.tools pacakge to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @weshaggard @danmosemsft @tarekgh @JeremyKuhne
Fixing MemoryMappedFiles tests by referencing the new uap tools package which contains a change in the manifest that will enable codeGeneration feature for our tests.
Also worth noting is that after this is merged, contributors will be able to run uap (UWP on CoreCLR) tests on their machines as well, which was not supported before (cc: @hughbe ).
This PR is doing part of the work that #20956 was doing, so I will have to rebase that PR once this is merged. I did do a Helix private run with these new package and for uap we are down to ~380 failures after this. (from ~520 failures 😄)