This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix DeflateStream Performance test #21050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stephentoub, Right now, we enter the while (retCount != 0) loop once. After you break (after first iteration of benchmark), retCount will be 0 and you will not enter the loop again for subsequent Benchmark.Iterations. |
ianhays
reviewed
Jun 14, 2017
| [Benchmark] | ||
| private const int Iter = 1000; | ||
|
|
||
| [Benchmark(InnerIterationCount = Iter)] |
There was a problem hiding this comment.
This is reducing the number of inner iterations from 10000 to 1000. Is that on purpose, and if so, why?
|
@ianhays Because on 10000 inner iterations we'll have only 1 Iteration of Benchmark, which doesn't show as an ok average time. So I reduced it to have more than 1 iteration of Benchmark and get a stable results. |
stephentoub
approved these changes
Jun 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.