Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Store Activity wrapped into ObjectHandle in Logical CallContext #21056

Closed

Conversation

lmolkova
Copy link

Request to merge #20963 into releae/2.0.0
Addresses #21027

Is not approved by shiproom so far

@stephentoub stephentoub added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Jun 14, 2017
@karelz karelz added this to the 2.0.0 milestone Jun 15, 2017
@stephentoub
Copy link
Member

Should this be closed?

@karelz
Copy link
Member

karelz commented Jun 29, 2017

@lmolkova @vancem what is the status of this 2.0 PR?

@vancem
Copy link
Contributor

vancem commented Jun 29, 2017

We have fixed this bug (in the master branch, which corresponds to 2.1), and @lmolkova opened this to port it to 2.0, but in E-mail I believe we decided that it was OK to just live with it.

I think this can be closed.

@lmolkova ?

@karelz
Copy link
Member

karelz commented Jun 30, 2017

@lmolkova is OOF this week (maybe also on Mon), can you please ping the email thread with managers @vancem?

@vancem
Copy link
Contributor

vancem commented Jun 30, 2017

I have sent the e-mail to possibly interested parties. The bottom line however, is that this fix is important enough for heroic measures. It will already naturally get fixed in the next release.

@vancem vancem closed this Jun 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Diagnostics.Tracing * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants