This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Disable test in System.Net.Sockets for UAPAOT #21058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caesar-chen
added
api-approved
caesar-chen
added
area-System.Net.Sockets
and removed
api-approved
stephentoub
reviewed
Jun 14, 2017
| @@ -623,6 +623,7 @@ public void Ctor_NotConnected_ThrowsIOException() | |||
| [InlineData(4096)] | |||
| [InlineData(4095)] | |||
| [InlineData(1024*1024)] | |||
| [ActiveIssue(20135, TargetFrameworkMonikers.Uap)] | |||
There was a problem hiding this comment.
I looked at the issue, but there's not much detail in there. Is the relevant work known / being tracked somewhere?
There was a problem hiding this comment.
Our current mission is to make all tests run clean for UWP. There is no known issue to track the problem, because I'm still investigating it. My following work for S.N.Sockets is to solve those ActiveIssue label: submit a fix or open a new issue.
cc: @davidsh
stephentoub
approved these changes
Jun 14, 2017
davidsh
approved these changes
Jun 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now all Sockets Functional tests (innerloop and outerloop) can run clean on both UAP and UAPAOT mode.
Contributes to: #20135