This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Hotfix for the Alpine CI issue #25806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Alpine CI is failing due to an old version of dotnet host package specified in the dependencies.props file. There are no Alpine packages for that version. However, updating that version causes Invariant.Tests tests to fail for an unclear reason. So I am making this change that disables building tests for Alpine in the CI. That means we will still build both native and managed code of corefx. This change is temporary until the Invariant test issue is understood and fixed.
weshaggard
reviewed
Dec 8, 2017
| @@ -24,10 +24,10 @@ simpleDockerNode('microsoft/dotnet-buildtools-prereqs:alpine-3.6-3148f11-2017111 | |||
| sh "./build-managed.sh -runtimeos=alpine.3.6 -- /t:GenerateVersionSourceFile /p:GenerateVersionSourceFile=true /p:PortableBuild=false" | |||
| } | |||
| stage ('Sync') { | |||
| sh "./sync.sh -p -runtimeos=alpine.3.6 -- /p:ArchGroup=x64 /p:PortableBuild=false" | |||
| sh "./sync.sh -p -runtimeos=alpine.3.6 -BuildTests=false -- /p:ArchGroup=x64 /p:PortableBuild=false" | |||
There was a problem hiding this comment.
Is this a supported parameter to sync? If so is it needed?
There was a problem hiding this comment.
It is supported. We currently use it in the official builds. It ensures that the test runtime stuff will not get restored. I'd prefer using the same parameters on sync and build
weshaggard
approved these changes
Dec 8, 2017
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
The Alpine CI is failing due to an old version of dotnet host package specified in the dependencies.props file. There are no Alpine packages for that version. However, updating that version causes Invariant.Tests tests to fail for an unclear reason. So I am making this change that disables building tests for Alpine in the CI. That means we will still build both native and managed code of corefx. This change is temporary until the Invariant test issue is understood and fixed. Commit migrated from dotnet/corefx@cf9a693
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Alpine CI is failing due to an old version of dotnet host package
specified in the dependencies.props file. There are no Alpine packages
for that version. However, updating that version causes Invariant.Tests
tests to fail for an unclear reason.
So I am making this change that disables building tests for Alpine in
the CI. That means we will still build both native and managed code of
corefx. This change is temporary until the Invariant test issue is
understood and fixed.