This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Test: ignore specific WinHttpException on old Windows versions #26428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root cause issue was already fixed in Windows but old versions still hit this issue. This change makes the failing test to ignore the known issue on these old Windows versions. Fixes #7812 (just so GH closes the issue at merge time, the actual issue was fixed in Windows).
pjanotti
commented
Jan 18, 2018
| @@ -1333,16 +1333,11 @@ private RendezvousAwaitable<int> InternalSendRequestAsync(WinHttpRequestState st | |||
| 0, | |||
| state.ToIntPtr())) | |||
| { | |||
| int lastError = Marshal.GetLastWin32Error(); | |||
There was a problem hiding this comment.
I am removing this one and other location that I see was added during the time of the investigation of the original bug, let me know if there is a reason to keep them.
davidsh
approved these changes
Jan 18, 2018
|
@dotnet-bot test Outerloop Linux x64 Debug Build |
|
@dotnet-bot test OSX x64 Debug Build |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…t/corefx#26428) The root cause issue was already fixed in Windows but old versions still hit this issue. This change makes the failing test to ignore the known issue on these old Windows versions. Fixes dotnet/corefx#7812 (just so GH closes the issue at merge time, the actual issue was fixed in Windows). Commit migrated from dotnet/corefx@f345a22
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause issue was already fixed in Windows but old versions still hit this issue. This change makes the intermittently failing test to ignore the known issue on these old Windows versions.
Fixes #7812 (just so GH closes the issue at merge time, the actual issue was fixed in Windows).