This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Enable ClientAndServer_OneOrBothUseDefault_Ok test #26463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protected against error in old versions of Windows and updated assert to include the case when hash algorithm can be Sha1. Fixes #7812 (actual fix done on Windows, just re-enabling affected tests with proper guard)
Priya91
reviewed
Jan 19, 2018
| if (PlatformDetection.IsWindows && PlatformDetection.WindowsVersion >= 10) | ||
| try | ||
| { | ||
| await Task.WhenAll(tasks); |
There was a problem hiding this comment.
Use Task.WhenAllOrAnyFailedWithTimeout, so that the tests don't hang and timeout with networking test timeout limit..
There was a problem hiding this comment.
Good idea, I wasn't aware that such extension method had been added to TestConfiguration for the Security tests. Thanks.
added 2 commits
January 19, 2018 15:37
On Windows 7 only Tls is supported OOB, so only few test cases can actually pass. Others fail with: ```System.Security.Authentication.AuthenticationException : A call to SSPI failed, see inner exception. ---- System.ComponentModel.Win32Exception : The client and server cannot communicate, because they do not possess a common algorithm```
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Enable ClientAndServer_OneOrBothUseDefault_Ok test Protected against error in old versions of Windows and updated assert to include the case when hash algorithm can be Sha1. Fixes dotnet/corefx#7812 (actual fix done on Windows, just re-enabling affected tests with proper guard) * Waiting for tasks w/ test cfg wrapper * Skip test on Windows 7 On Windows 7 only Tls is supported OOB, so only few test cases can actually pass. Others fail with: ``` System.Security.Authentication.AuthenticationException : A call to SSPI failed, see inner exception. ---- System.ComponentModel.Win32Exception : The client and server cannot communicate, because they do not possess a common algorithm ``` Commit migrated from dotnet/corefx@9f858d0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protected against error in old versions of Windows and updated assert to
include the case when hash algorithm can be Sha1.
Fixes #7812 (actual fix done on Windows, just re-enabling affected tests
with proper guard)