This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Use ValueTask shared from corelib #26636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
stephentoub
force-pushed
the
valuetaskruntime
branch
from
ad37479
to
6395727
Compare
|
Depends on dotnet/coreclr#16098 being merged and mirrored to corefx. |
stephentoub
changed the title
stephentoub
force-pushed
the
valuetaskruntime
branch
from
6395727
to
724a776
Compare
jkotas
reviewed
Jan 31, 2018
src/Common/src/System/ThrowHelper.cs
Outdated
|
|
||
| namespace System | ||
| { | ||
| internal static class ThrowHelper |
There was a problem hiding this comment.
I do not think that the ThrowHelper should be common. It should be always local to the project to avoid bloating every assembly with every other assembly exception messages.
stephentoub
force-pushed
the
valuetaskruntime
branch
3 times, most recently
from
f9cad42
to
3b67051
Compare
stephentoub
force-pushed
the
valuetaskruntime
branch
from
3b67051
to
ca709ef
Compare
dotnet-bot
pushed a commit
to dotnet/coreclr
that referenced
this pull request
Feb 1, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/coreclr
that referenced
this pull request
Feb 1, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
to dotnet/corert
that referenced
this pull request
Feb 2, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com> Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Feb 2, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com> Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/corefx@7b6abc2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @kouvel, @jkotas
Closes https://github.com/dotnet/corefx/issues/22171