Enable SendReceive_VaryingLengthBuffers_Success on Windows run #27181
Conversation
| @@ -0,0 +1,14 @@ | |||
| SETLOCAL EnableDelayedExpansion | |||
There was a problem hiding this comment.
Did you mean to add this file?
There was a problem hiding this comment.
No... It's removed in the new commit.
|
|
||
| for /L %%x in (1,1,500) do ( | ||
|
|
||
| mkdir "D:/TestDiag/Run %%x" |
There was a problem hiding this comment.
I don't recommend we hard code drive letters in these scripts. Not everyone has a "D:" drive. I don't for example. I have my other drives set to letters like "S:" (enlistments) and "W:" (work stuff)
| msbuild /t:rebuildandtest > "D:/TestDiag/Run %%x/output.log" | ||
|
|
||
| IF NOT ERRORLEVEL 1 ( | ||
| rmdir "D:/TestDiag/Run %%x/" /s /q |
There was a problem hiding this comment.
same comment as above about drive letters.
|
It looks like the only failures in windows were on 8.1 and not 10. I think it might be worth trying to recreate the situation more closely by running the script in a VM on 8.1. |
Weren't those Win 8.1 failures a while ago and when we had the WinHTTP implementation for Windows? Now, we use the managed sockets implementation for both Linux and Windows. So, maybe getting failures on Win 8.1 won't be possible (or the same type of failure) as before. |
|
I hadn't considered the switch from WinHTTP to managed sockets. Since the code under test has changed, this looks good to me. |
|
@dotnet-bot test Outerloop Windows x64 Debug Build |
Yes, I found the related PR here: #26429. If there is no failure reported after this PR get merged, we can consider enable the test and close #23765. |
|
Unrelated failure: System.Net.WebSockets.Client.Tests.CancelTest/CloseAsync_Cancel_Success(server: ws://corefx-net.cloudapp.net/WebSocket/EchoWebSocket.ashx) I can open a new issue and investigate it. (Doesn't look like this issue #22904) |
|
@dotnet-bot test Outerloop Windows x64 Debug Build |
|
@dotnet-bot test Windows x86 Release Build please |
|
Disable @dotnet-bot test Outerloop Windows x64 Debug Build |
|
Disable @dotnet-bot test Outerloop Windows x64 Debug Build |
|
Have you gotten a chance to look and see when those tests started failing? |
…t#27181) * enable test on Windows run * delete script * disable test issue #27211 * disable test see #27217
…t/corefx#27181) * enable test on Windows run * delete script * disable test issue dotnet/corefx#27211 * disable test see dotnet/corefx#27217 Commit migrated from dotnet/corefx@d3a69ff
Have run the test 500 times on local Windows 10 machine. No failure. The previous stack trace #22845 is too old, cannot reflect which code path results in this failure.
Enable the test on Windows to see if it fails in CI. If it fails, I can investigate further.
Related: #23765