This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add GetPosition overload to ReadOnlySequence #27633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym
reviewed
Mar 1, 2018
| SequencePosition c1 = buffer.GetPosition(buffer.Start, 0); | ||
| Assert.Equal(0, c1.GetInteger()); | ||
| Assert.Equal(bufferSegment1, c1.GetObject()); | ||
| { |
pakrym
reviewed
Mar 1, 2018
| SequencePosition c1 = buffer.GetPosition(buffer.Start, 0); | ||
| Assert.Equal(0, c1.GetInteger()); | ||
| Assert.Equal(bufferSegment1, c1.GetObject()); | ||
| { |
| @@ -24,11 +24,17 @@ public void SegmentStartIsConsideredInBoundsCheck() | |||
|
|
|||
| var buffer = new ReadOnlySequence<byte>(bufferSegment1, 0, bufferSegment2, 50); | |||
|
|
|||
| SequencePosition c1 = buffer.GetPosition(buffer.Start, 25); // segment 1 index 75 | |||
| SequencePosition c2 = buffer.GetPosition(buffer.Start, 55); // segment 2 index 5 | |||
| SequencePosition c1 = buffer.GetPosition(25); // segment 1 index 75 | |||
There was a problem hiding this comment.
I wonder if we should not call the API "PositionAt" (or GetPositionAt). It would allow us to add PositionOf(byte value) in the future without having problems with inconsistent names or overloads.
There was a problem hiding this comment.
We already have PositionOf(byte value) extension method.
There was a problem hiding this comment.
That is my point. We will endup with GetPosition and PositionOf, which is inconsistent. It would be better to have either PositionAt and PositionOf or GetPositionAt and GetPositionOf.
pakrym
approved these changes
Mar 2, 2018
|
@dotnet-bot test Windows x64 Debug Build |
|
@dotnet-bot test Linux x64 Release Build |
|
@dotnet-bot test Windows x64 Debug Build |
davidfowl
reviewed
Mar 2, 2018
| @@ -34,7 +34,7 @@ public void AdvanceThrowsIfFlushActiveAndNotConsumedPastThreshold() | |||
| Assert.False(flushAsync.IsCompleted); | |||
|
|
|||
| ReadResult result = _pipe.Reader.ReadAsync().GetAwaiter().GetResult(); | |||
| SequencePosition consumed = result.Buffer.GetPosition(result.Buffer.Start, 31); | |||
| SequencePosition consumed = result.Buffer.GetPosition(31, result.Buffer.Start); | |||
There was a problem hiding this comment.
Change this to just specify the length without the position for the ones that pass start.
davidfowl
reviewed
Mar 2, 2018
| @@ -19,7 +19,7 @@ public static class BuffersExtensions | |||
| int index = sequence.First.Span.IndexOf(value); | |||
| if (index != -1) | |||
| { | |||
| return sequence.GetPosition(sequence.Start, index); | |||
| return sequence.GetPosition(index, sequence.Start); | |||
|
@dotnet-bot test OSX x64 Debug Build |
|
I am going to ignore the OSX and UWP legs (recently enabled - #27531) that are failing: https://github.com/dotnet/core-eng/issues/2808 |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Add GetPosition overload to ReadOnlySequence * Address feedback (split tests) * Use new GetPosition overload whenever passing start is redundant. Commit migrated from dotnet/corefx@9ff60da
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/dotnet/corefx/issues/27403
cc @pakrym, @davidfowl, @halter73, @KrzysztofCwalina