This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add more test coverage for System.Reflection.Pointer #28143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test that null object reference is properly converted to a null pointer value (this requires special handling) * Test `Delegate.DynamicInvoke`. This one also uses `System.Reflection.Pointer` and on .NET Native is handled by separate code paths.
MichalStrehovsky
force-pushed
the
morePointerTests
branch
from
0b9e8ed
to
e740426
Compare
|
@dotnet-bot test Linux x64 Release Build |
stephentoub
reviewed
Mar 19, 2018
| { | ||
| var obj = new PointerHolder(); | ||
| MethodInfo method = typeof(PointerHolder).GetMethod("Method"); | ||
| method.Invoke(obj, new object[] { null, 0 }); |
There was a problem hiding this comment.
Is there anything to assert, or we're just verifying it doesn't throw/crash?
There was a problem hiding this comment.
The body of the invoked method has Assert.Equal(expected, unchecked((int)ptr));
stephentoub
approved these changes
Mar 19, 2018
ericstj
pushed a commit
to ericstj/corefx
that referenced
this pull request
Mar 28, 2018
* Test that null object reference is properly converted to a null pointer value (this requires special handling) * Test `Delegate.DynamicInvoke`. This one also uses `System.Reflection.Pointer` and on .NET Native is handled by separate code paths.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…8143) * Test that null object reference is properly converted to a null pointer value (this requires special handling) * Test `Delegate.DynamicInvoke`. This one also uses `System.Reflection.Pointer` and on .NET Native is handled by separate code paths. Commit migrated from dotnet/corefx@b287402
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delegate.DynamicInvoke. This one also usesSystem.Reflection.Pointerand on .NET Native is handled by separate code paths.Currently adding as disabled on UapAot because I'm working on that support right now. We'll unblock it with the rest later.
Cc @sergiy-k