This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add Brotli support to SocketsHttpHandler #29729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsh
approved these changes
May 15, 2018
joshfree
approved these changes
May 15, 2018
ianhays
approved these changes
May 15, 2018
|
Thanks @stephentoub related asp.net issue aspnet/BasicMiddleware#217 |
geoffkizer
reviewed
May 16, 2018
| @@ -9,6 +9,7 @@ public enum DecompressionMethods | |||
| { | |||
| None = 0, | |||
| GZip = 1, | |||
| Deflate = 2 | |||
| Deflate = 2, | |||
There was a problem hiding this comment.
Nit: Why not specify using binary (or hex) constants instead of decimal?
There was a problem hiding this comment.
I was just following suit on what was already done. But I can change it to hex.
geoffkizer
approved these changes
May 16, 2018
- Add DecompressionMethods.Brotli - Add support for Brotli to SocketsHttpHandler - Add some tests
|
@dotnet-bot test Windows x64 Debug Build please (lots of unrelated failures on the Nano server leg... looks like the system is in a bad state) |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Add Brotli support to SocketsHttpHandler - Add DecompressionMethods.Brotli - Add support for Brotli to SocketsHttpHandler - Add some tests * Address PR feedback Commit migrated from dotnet/corefx@91f2cd7
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/corefx/issues/26995
cc: @ianhays, @joshfree, @geoffkizer, @davidsh