This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add Xamarin placeholder in System.threading.Tasks.Extensions packages #29922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is adding a placeholder in the System.Threading.Tasks.Extensions package as Xamarin going to have inbox implementation library. Also, the change here is removing the placeholder in System.Memory package as this didn't work nicely for Xamarin
|
@tarekgh could you do a individual commit for each fix? I only ask for that as I expect we will need to revert at least the System.Memory change in the future and it will be easier to revert an individual commit. |
|
CI failure in Windows x64 Debug Build is tracked by the issue https://github.com/dotnet/corefx/issues/19223 |
|
@weshaggard ok, I'll split them |
tarekgh
changed the title
weshaggard
approved these changes
May 25, 2018
weshaggard
approved these changes
May 25, 2018
|
Test Windows x64 Debug Build please |
|
Linking the tracking issues for the unrelated Windows x64 Debug Build failed CI tests: #15065 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is adding a placeholder in the System.Threading.Tasks.Extensions package as Xamarin going to have inbox implementation library.
Fixes #29585