This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Revert "Expose Marshall.LoadLibrary API" #34322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In API review: https://github.com/dotnet/corefx/issues/32015, The LoadLibrary APIs were originally Approved to live in System.Runtime.InteropServices.Marshal class. https://github.com/dotnet/corefx/issues/32015#issuecomment-428775858 However, recently the decision was changed such that the APIs are in a new NativeLibrary class. https://github.com/dotnet/corefx/issues/32015#issuecomment-448324606 Therefore, undoing the changes to Marshal API. I'll submit another PR for System.Runtime.InteropServices.NativeLibrary once the corresponding change in CoreCLR is checked in. This reverts commit 859351c.
jkotas
approved these changes
Jan 3, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
In API review: https://github.com/dotnet/corefx/issues/32015, The LoadLibrary APIs were originally Approved to live in System.Runtime.InteropServices.Marshal class. https://github.com/dotnet/corefx/issues/32015#issuecomment-428775858 However, recently the decision was changed such that the APIs are in a new NativeLibrary class. https://github.com/dotnet/corefx/issues/32015#issuecomment-448324606 Therefore, undoing the changes to Marshal API. I'll submit another PR for System.Runtime.InteropServices.NativeLibrary once the corresponding change in CoreCLR is checked in. This reverts commit dotnet/corefx@859351c. Commit migrated from dotnet/corefx@6d59e6a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In API review: https://github.com/dotnet/corefx/issues/32015,
The LoadLibrary APIs were originally Approved to live in
System.Runtime.InteropServices.Marshal class.
https://github.com/dotnet/corefx/issues/32015#issuecomment-428775858
However, recently the decision was changed such that the APIs are in a new NativeLibrary class.
https://github.com/dotnet/corefx/issues/32015#issuecomment-448324606
Therefore, undoing the changes to Marshal API.
I'll submit another PR for System.Runtime.InteropServices.NativeLibrary
once the corresponding change in CoreCLR is checked in.
This reverts commit 859351c.