Generate System.Runtime ref assembly against implementation #37737
Conversation
| { | ||
| public partial class TypeDelegator | ||
| { | ||
| public override bool IsVariableBoundArray { get { throw null; } } |
There was a problem hiding this comment.
Why does this need to be manual? This looks like a bug in the implementation that this is working around.
There was a problem hiding this comment.
Because this override doesn’t exist in the implementation. I tried to see when it was added but it was added on the initial commit to corefx. The implementation in coreclr has never had it.
Since the implementation doesn’t have it, if you run GenAPI it would remove it, so to avoid that I moved it to Manual.
There was a problem hiding this comment.
Since the implementation doesn’t have it,
Right - this looks like an oversight in the implementation. It would be better to fix the implementation instead of adding a workaround here.
There was a problem hiding this comment.
Ok, I'll fix the implementation and put this back on the generated ref assembly.
|
Any other concerns before I merge? |
…orefx#37737) * Generate System.Runtime ref assembly against implementation * PR Feedback and baseline uapaot errors Commit migrated from dotnet/corefx@959168e
We're about to add Nullable Annotations from Corelib's implementation into System.Runtime reference assembly. In order to make the diff easier when adding those annotations and reducing noise I generated the reference assembly again against the implementation.
Some things that stand out are:
(T1, ..., TN)syntax. I.e: Before a nested ValueTuple would look like:(T1, System.ValueTuple<T2, T3>). After my change now they will be emitted as follows:(T1, (T2, T3)).cc: @stephentoub @danmosemsft @ericstj @tannergooding @ahsonkhan @terrajobst