This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Re-generate System.Collections.Immutable ref assembly and fix a param name #38264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrajobst
reviewed
Jun 5, 2019
src/System.Collections.Immutable/src/System/Collections/Immutable/ImmutableSortedDictionary.cs
Outdated
Show resolved
Hide resolved
safern
force-pushed
the
NormalizeSystemCollectionsImmutable
branch
from
13ec5f2
to
b794c56
Compare
|
This is ready to be merged. PTAL |
ahsonkhan
reviewed
Jun 15, 2019
| @@ -96,7 +96,7 @@ public static partial class ImmutableArray | |||
| } | |||
| public partial struct ImmutableArray<T> : System.Collections.Generic.ICollection<T>, System.Collections.Generic.IEnumerable<T>, System.Collections.Generic.IList<T>, System.Collections.Generic.IReadOnlyCollection<T>, System.Collections.Generic.IReadOnlyList<T>, System.Collections.ICollection, System.Collections.IEnumerable, System.Collections.IList, System.Collections.Immutable.IImmutableList<T>, System.Collections.IStructuralComparable, System.Collections.IStructuralEquatable, System.IEquatable<System.Collections.Immutable.ImmutableArray<T>> | |||
| { | |||
| internal T[] array; | |||
| private T[] array; | |||
There was a problem hiding this comment.
Question: How do we know this is the right change (internal -> private)?
There was a problem hiding this comment.
This is fine, as long as it is what GenAPI generates.
There was a problem hiding this comment.
Since the ref doesn't have an [InternalsVisibleTo] there shouldn't be any observable difference in those access levels.
ahsonkhan
approved these changes
Jun 15, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
… name (dotnet/corefx#38264) * Re-generate System.Collections.Immutable ref assembly and fix a param name * Use builder as the param name instead Commit migrated from dotnet/corefx@2e6661d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/dotnet/corefx/issues/38110
Picked to preserve
sourceas the param name since that is what we use in other APIs, so I wanted to be consistent.cc: @stephentoub @ahsonkhan @danmosemsft