This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Remove cancellation token from new System.Data CloseAsync() (#39070) #39122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9070) Affects DbDataReader and DbConnection, since these APIs are very likely to be used for cleanup only, in which case a cancellation token is an anti-pattern (similar to why DisposeAsync doesn't accept one). See discussion here: dotnet/standard#1283 (review) Fixes #39069
|
@roji that's correct |
|
@wtgodbe will you be taking care of merging this today or is there any action required from us? |
|
@divega I'm going to merge this as soon as CI is green |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affects DbDataReader and DbConnection, since these APIs are very likely
to be used for cleanup only, in which case a cancellation token is
an anti-pattern (similar to why DisposeAsync doesn't accept one).
See discussion here:
dotnet/standard#1283 (review)
Fixes #39069
Has been approved for preview7
CC @danmosemsft @roji @terrajobst