This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Do not use DictionaryKeyPolicy on deserialization #39392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveharter
reviewed
Jul 11, 2019
|
|
||
| Assert.Equal(2, obj[1].Count); | ||
| Assert.Equal(3, obj[1]["Key1"]); | ||
| Assert.Equal(4, obj[1]["Key2"]); |
There was a problem hiding this comment.
Can you add the serialize case to make sure Key1->key1 when the policy is applied.
There was a problem hiding this comment.
It's here -
.
JamesNK
approved these changes
Jul 12, 2019
|
Can you update the docs to indicate that the policy is ignored on deserialization: |
ahsonkhan
reviewed
Nov 26, 2019
| } | ||
|
|
||
| [Fact] | ||
| public static void KeyConflictDeserialize_LastValueWins() |
There was a problem hiding this comment.
Isn't this still a useful test case? What do we do for this case now since we are no longer using naming policy when deserializing? The behavior should be captured in a test.
ahsonkhan
reviewed
Nov 26, 2019
| ThrowHelper.ThrowInvalidOperationException_SerializerDictionaryKeyNull(options.DictionaryKeyPolicy.GetType()); | ||
| } | ||
|
|
||
| keyName = options.DictionaryKeyPolicy.ConvertName(keyName); |
There was a problem hiding this comment.
Out of curiosity, why did we initially try to get the keyName by calling ConvertName twice?
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Do not use DictionaryKeyPolicy on deserialization * Update policy doc Commit migrated from dotnet/corefx@ba8641a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/corefx/issues/39207.
cc @JamesNK