This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.0] SqlClient fix for managed encryption connection failure #40825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @cheenamalhotra could you please get someone to sign off? |
|
Also, briefly did this regress because of missing test coverage, or because we didn't run the manual tests? 😺 |
|
The Manual tests were run but not with encrypted connection string.. It was missing test coverage I would say. |
yukiwongky
approved these changes
Sep 5, 2019
yukiwongky
approved these changes
Sep 5, 2019
And this test hole is now plugged in the manual script? Just asking because tactics will ask 😺 |
|
We're taking care of the testing externally by running Manual Tests with Encryption enabled connection string. |
|
approved. |
Anipik
pushed a commit
that referenced
this pull request
Sep 6, 2019
* update branding of rc1 to rc2 * [release/3.0] SqlClient fix for managed encryption connection failure (#40825) * Update dependencies from https://github.com/dotnet/coreclr build 20190905.5 (#40856) - Microsoft.NET.Sdk.IL - 3.0.0-rc1.19455.5 - Microsoft.NETCore.ILAsm - 3.0.0-rc1.19455.5 - Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-rc1.19455.5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #40732 to release/3.0
Resolves #40476
Description
Fixes a bug in encapsulation of SSL over TDS when connecting to SQL Server using the managed SNI implementation (non-windows and uap). This is a slight rework of the original code with enhancements but is mainly targeted to revert changes done in earlier PR #35363 that caused regression.
Customer Impact
All Unix and UAP customers are impacted as they cannot connect to SQL Server with SSL enabled.
Regression
Yes. This PR fixes a regression reported in #40476 caused with PR #35363 in .NET Core SDK 3.0 Preview7.
Risk
Small. The change-set is small and selective code introduced in earlier PR #35363 is being reverted here.
Tests
No tests added as part of this change. Existing manual tests were run with Encryption enabled in connection string to validate regression issues.