This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Setting version suffix as non empty for building release package versions #41040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmitche
approved these changes
Sep 11, 2019
|
@mmitche the netstandard change still requires some extra work. i will try to complete that tomorrow. |
|
Okay. How much work? We are on a very tight timeline...we need to be done with it in by noon. |
I can get it merged by noon. Its small change, just needs to find a correct place for it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are getting this error while building packages in release mode
Corefx does not depend on version suffix property to check if any of the dependencies are stable or not. We use packageIndex.Json file for that check.
We always require version suffix to be not null.