This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Fix SqlParameter with xml schema construction #41178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port PR dotnet#41008 for Release 3.1
karinazhou
approved these changes
Sep 18, 2019
|
Customer reported regression. Approved for 3.1. @Anipik is 3.1 branch open? If so this can merge |
|
Yes 3.1 branch is open for changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #41008 for release/3.1
Description
Fixes a bug in SqlParameter XmlSchemaCollection APIs where setters were not validating initialized xmlSchemaCollection properly. The issue got merged in due to no test coverage on impacted APIs.
Customer Impact
Below SqlParameter APIs are impacted:
Regression
Yes. This PR fixes a regression reported in #41141 caused with PR #35549 in .NET Core SDK 3.0 Preview3.
Risk
Small. The change-set is small and the code changes introduced in earlier PR #35363 is being revised here.
Tests
Tests added to cover missing areas and will now be run as part of PR validations.