Use Package suffix instead of PackageId and Version suffix instead of PackageVersion #42289
Conversation
ViktorHofer
force-pushed
the
ConsolidatePackageIdSuffix
branch
from
83f4728 to
8bec599
Compare
ViktorHofer
changed the title
|
I will update this PR as soon as an Arcade build is available. |
ViktorHofer
force-pushed
the
ConsolidatePackageIdSuffix
branch
from
8bec599 to
9874469
Compare
ViktorHofer
force-pushed
the
ConsolidatePackageIdSuffix
branch
from
9874469 to
17ba1f9
Compare
|
@maryamariyan @danmosemsft In cases where we do changes like this one, tagging every area-owner doesn't make much sense. I already requested a review from @safern here. Especially in the new runtime repo where we will have area-owners from the different sub-repos. |
|
@ViktorHofer I just ran a one-time script to request review from area owners for each of the open PRs. So just to confirm, your recommendation is for future, not to assign the rest of the owners if one has already been requested? |
|
We should probably do a bit more thinking about how to best tag owners so it's useful without making lots of noise as well. We could wait til after hte repo merge I think |
|
Of course this can wait. Just wanna share my opinion in case you want to do this more regularly. |
|
Merging as the build has completed (and the previous run was green). |
… PackageVersion (dotnet/corefx#42289) * Use Package suffix instead of PackageId * Manual darc update from build '20191101.2' Commit migrated from dotnet/corefx@931f79e
I'm consolidating all the version properties to use the
Versionsuffix instead ofPackageVersion. This aligns to Arcade conventions and extension point which also use theVersionsuffix.Requires dotnet/arcade#4266