Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Use Package suffix instead of PackageId and Version suffix instead of PackageVersion #42289

Merged
merged 3 commits into from
Nov 1, 2019
Merged

Use Package suffix instead of PackageId and Version suffix instead of PackageVersion #42289

merged 3 commits into from
Nov 1, 2019

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Nov 1, 2019 •
edited
Loading

I'm consolidating all the version properties to use the Version suffix instead of PackageVersion. This aligns to Arcade conventions and extension point which also use the Version suffix.

Requires dotnet/arcade#4266

@ViktorHofer ViktorHofer self-assigned this Nov 1, 2019
@ViktorHofer ViktorHofer mentioned this pull request Nov 1, 2019
Merged
@ViktorHofer ViktorHofer changed the title Use Package suffix instead of PackageId Use Package suffix instead of PackageId and Version suffix instead of PackageVersion Nov 1, 2019
@ViktorHofer
Copy link
Member Author

I will update this PR as soon as an Arcade build is available.

@ViktorHofer
Copy link
Member Author

@maryamariyan @danmosemsft In cases where we do changes like this one, tagging every area-owner doesn't make much sense. I already requested a review from @safern here. Especially in the new runtime repo where we will have area-owners from the different sub-repos.

@maryamariyan
Copy link
Member

@ViktorHofer I just ran a one-time script to request review from area owners for each of the open PRs.

So just to confirm, your recommendation is for future, not to assign the rest of the owners if one has already been requested?

@danmoseley
Copy link
Member

We should probably do a bit more thinking about how to best tag owners so it's useful without making lots of noise as well. We could wait til after hte repo merge I think

@ViktorHofer
Copy link
Member Author

Of course this can wait. Just wanna share my opinion in case you want to do this more regularly.

safern
safern reviewed Nov 1, 2019
View reviewed changes
eng/Versions.props Outdated Show resolved Hide resolved
safern
safern approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one comment LGTM

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Nov 1, 2019 •
edited
Loading

Merging as the build has completed (and the previous run was green).

@ViktorHofer ViktorHofer merged commit 931f79e into dotnet:master Nov 1, 2019
@ViktorHofer ViktorHofer deleted the ConsolidatePackageIdSuffix branch November 1, 2019 17:27
@karelz karelz added this to the 5.0 milestone Dec 19, 2019
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@ViktorHofer
Use Package suffix instead of PackageId and Version suffix instead of…
926874e 
… PackageVersion (dotnet/corefx#42289)

* Use Package suffix instead of PackageId

* Manual darc update from build '20191101.2'


Commit migrated from dotnet/corefx@931f79e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern approved these changes

@Anipik Anipik Awaiting requested review from Anipik

@ericstj ericstj Awaiting requested review from ericstj

@wtgodbe wtgodbe Awaiting requested review from wtgodbe

Assignees

@ViktorHofer ViktorHofer

Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ViktorHofer @maryamariyan @danmoseley @safern @karelz