This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
SmtpConnection: fix Socket not getting Disposed when LingerState cannot be set. #42664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsh
added
the
* NO MERGE *
|
We're currently not accepting any PRs on this corefx repo. We'll be publishing the new dotnet/runtime repo in the next several days. |
stephentoub
reviewed
Nov 23, 2019
| { | ||
| _tcpClient.LingerState = new LingerOption(true, 0); | ||
| } | ||
| catch |
There was a problem hiding this comment.
Can we catch the exact problematic exception type?
There was a problem hiding this comment.
The dump indicates that we don't get past this line.
But we don't know what exact exception gets thrown.
|
Replaced by dotnet/runtime#428. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/corefx/issues/40711
cc @stephentoub