Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Commit

Permalink
Suspension fixes (dotnet/coreclr#27578)
Browse files Browse the repository at this point in the history
* Two simple fixes to suspension issues seen in GCPerfSim:

- Insert allow_fgc() call in background_mark_simple - this fixes the cases where there are a ton of GC handles referencing simple objects not containing pointers.

- Change PING_JIT_TIMEOUT constant from 10 milliseconds to 1 millisecond. This fixes the case where return address hijacking doesn't work quickly, because the hijacked thread doesn't return (e.g. because it's in a loop doing further calls). In this case we have to retry the hijack, and changing the timeout constant makes this happen more quickly.

Commit migrated from dotnet/coreclr@fab7aa2
  • Loading branch information
PeterSolMS authored and jkotas committed Apr 1, 2020
1 parent 9b8b438 commit 41bd86d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/Native/gc/gc.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -19982,6 +19982,7 @@ gc_heap::background_mark_simple (uint8_t* o THREAD_NUMBER_DCL)
background_mark_simple1 (o THREAD_NUMBER_ARG);
}
}
allow_fgc();
}
}

Expand Down

0 comments on commit 41bd86d

Please sign in to comment.