Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Fix crashing on startup (#1596) #1604

Merged
merged 2 commits into from
Jul 29, 2016
Merged

Fix crashing on startup (#1596) #1604

merged 2 commits into from
Jul 29, 2016

Conversation

wjk
Copy link
Contributor

@wjk wjk commented Jul 29, 2016

I have put the currently broken code under #if !CORERT, as suggested by @jkotas. I have also added a TODO comment with a link to issue #1596, which discusses the context for this change.

@wjk
Copy link
Contributor Author

wjk commented Jul 29, 2016

@jkotas @dnfclas tells me I must sign the CLA, but has provided no link for me to do so (just the label stating that doing so is required). Any pointers?

@jkotas
Copy link
Member

jkotas commented Jul 29, 2016

The details about CLA are at the end of https://github.com/dotnet/coreclr/blob/master/Documentation/project-docs/contributing.md

I will look into adding this link to the front page to make it more discoverable.

@jkotas
Copy link
Member

jkotas commented Jul 29, 2016

The change looks good. Thanks!

@dnfclas
Copy link

dnfclas commented Jul 29, 2016

@wjk, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@jkotas jkotas merged commit a60a4de into dotnet:master Jul 29, 2016
@wjk wjk deleted the corert-issue-1596 branch July 29, 2016 23:00
MichalStrehovsky pushed a commit to MichalStrehovsky/corert that referenced this pull request Mar 28, 2020
MichalStrehovsky pushed a commit to MichalStrehovsky/corert that referenced this pull request Mar 31, 2020
jkotas pushed a commit that referenced this pull request Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants