Enable CoreFX tests on CoreRT #5329
Conversation
Shell scripts
tests/CoreFX/corerun
Outdated
| fi | ||
| #!/usr/bin/env bash | ||
|
|
||
| # This is the Unix equivalent of build-and-run-test.cmd |
There was a problem hiding this comment.
This looks like a copy&paste error. The same code included twice.
There was a problem hiding this comment.
Seems like something went wrong in revising commit history. Fixed.
tests/CoreFX/runtest/runtest.cmd
Outdated
| :Usage | ||
| echo. | ||
| echo Usage: | ||
| echo %0 BuildArch BuildType [SkipWrapperGeneration] [Exclude EXCLUSION_TARGETS] [TestEnv TEST_ENV_SCRIPT] [VSVersion] CORE_ROOT |
There was a problem hiding this comment.
What are these extra args after "BuildType"? They are not described in the usage and I don't see a reference to them.
|
Regarding the assert in GetConservativeUpperBoundForOutgoingArgs. Could you please share the call stack that leads to it? |
tests/CoreFX/corerun
Outdated
| then | ||
| exit ${__exitcode} | ||
| fi | ||
| #!/usr/bin/env bash |
There was a problem hiding this comment.
You probably still want to keep this line.
tests/TopN.CoreFX.issues.json
Outdated
| [ | ||
| "System.Collections.Tests", | ||
| "System.Collections.Immutable.Tests", | ||
| "System.Net.Security.Tests" |
There was a problem hiding this comment.
Could you please delete "System.Net.Security.Tests" from here. Instead, add System.Runtime, System.Runtime.Extensions, System.Threading, System.Threading.Tasks.
There was a problem hiding this comment.
Agree - "System.NET.Security.Tests" needs to be deleted as per previous discussions.
I would prefer to see more tests to be added as a separate PR once we know that this change works reliably.
|
Regarding this assertion: corert/src/Native/Runtime/windows/CoffNativeCodeManager.cpp Lines 375 to 376 in 3615b99 It fires when the runtime is scanning GC roots of the following stack: |
A-And
force-pushed
the
FXTestingFramework
branch
4 times, most recently
from
33285d6
to
67256bd
Compare
A-And
force-pushed
the
FXTestingFramework
branch
2 times, most recently
from
ef4a348
to
e339071
Compare
A-And
force-pushed
the
FXTestingFramework
branch
from
e339071
to
a802e5e
Compare
A-And
changed the title
* Generate Test projects - Intermittent checkin * Intermittent check-in running exe, tests need restoring * Add Test utitilites project * End-to-End test build Windows * Change structure * Fix RDXML and add reflectable types * Add json parsing and xml logs * End-to-end test run and display * Helper project style changes * Remove direct dll references add package dependencies * Stylistic changes + deps * Style fixup * XML reader escape * Dependency and comment cleanup * Respond to PR feedback * Intermittent checkin - Build helper projects Shell scripts * Building and working shell scripts * End-to-end build and run * Add error checking * Style Fixup * Address PR comments * Revert line change * Remove Net.Security.Tests * OSX Changes * Update URL; update dependencies * Remove Collections.Immutable and update to long-lasting URL
Dupe of #5287 - can't reopen the PR because of commit history. Adresses #5059
Addressed the comments on the last PR; Added Unix scripts.
The current blocker for is getting the CoreFX.Private.TestUtilities project published as a NuGet package.
Additionally - native assertions will cause the XUnit runner to crash - e.g.
corert/src/Native/Runtime/windows/CoffNativeCodeManager.cpp
Lines 375 to 376 in 3615b99
will be called when executing System.Runtime.Tests and freeze the executable until the user hits Ctrl-C. Do we need a way around errors like this?