This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
[ObjWriter] Add IMAGE_REL_BASED_RELPTR32 relocs support #5380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dotnet#3278 - Enabled only for ARM32. When ObjWriter is remotely updated, it will be possible to completely remove this workaround for other archs. Signed-off-by: Petr Bred <bredpetr@gmail.com>
Agree - #5177 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jkotas Need to rebuild and update ObjWriter remotely in repos, so that we can enable it for all architectures, including x64.
@dotnet/arm32-corert-contrib please review